Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datasets): add created_by to ApiToken for get datasets from api correct current user #11450

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

hgbdev
Copy link
Contributor

@hgbdev hgbdev commented Dec 7, 2024

Summary

This PR Fixes #11331. The problem was that admin-created API keys always showed the owner’s dataset list, even when the owner set “Only Me” permissions.

I added a new field, created_by, to the ApiToken model to track who created each API key. This makes sure the correct user and permissions are used when accessing datasets.

In the web console, users will now only see the Datasets API keys they created. Old keys without the created_by field will still work fine.

Screenshots

Before After
image image
image image

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. 🐞 bug Something isn't working labels Dec 7, 2024
@crazywoola crazywoola requested a review from JohnJyong December 7, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The knowledge base query API only returns the initial user's knowledge base list.
1 participant