Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: continue on error #11458

Merged
merged 23 commits into from
Dec 11, 2024
Merged

Feat: continue on error #11458

merged 23 commits into from
Dec 11, 2024

Conversation

Nov1c444
Copy link
Contributor

@Nov1c444 Nov1c444 commented Dec 8, 2024

Summary

Added error handling method for four types of nodes: LLM, Tool, HTTP Request, and Code nodes. Errors can now be handled either by setting default values or by adding fail branches.

Close #11314

Screenshots

Before After
image image

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@Nov1c444 Nov1c444 requested a review from laipz8200 December 8, 2024 05:37
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. 🌊 feat:workflow Workflow related stuff. labels Dec 8, 2024
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Dec 8, 2024
crazywoola
crazywoola previously approved these changes Dec 9, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 9, 2024
@Nov1c444 Nov1c444 merged commit 79a710c into main Dec 11, 2024
9 checks passed
@Nov1c444 Nov1c444 deleted the feat/continue-on-error branch December 11, 2024 06:22
iamjoel pushed a commit that referenced this pull request Dec 16, 2024
Co-authored-by: Novice Lee <[email protected]>
Co-authored-by: Novice Lee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌊 feat:workflow Workflow related stuff. lgtm This PR has been approved by a maintainer size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

better error handling for professional flows
3 participants