Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove the unused retry index field #11903

Merged
merged 12 commits into from
Dec 23, 2024
Merged

Conversation

Nov1c444
Copy link
Contributor

@Nov1c444 Nov1c444 commented Dec 20, 2024

Summary

The retry_index field in the node_executions table was not actually functioning, so it has been removed. Additionally, the issue with retry logs in iteration nodes has been fixed.

Fixes #11871
Fixes #11896

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@Nov1c444 Nov1c444 requested a review from laipz8200 December 20, 2024 09:08
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. 🐞 bug Something isn't working labels Dec 20, 2024
crazywoola
crazywoola previously approved these changes Dec 20, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 20, 2024
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Dec 23, 2024
@laipz8200 laipz8200 merged commit c1aa55f into main Dec 23, 2024
9 checks passed
@laipz8200 laipz8200 deleted the fix/remove-the-retry-index-field branch December 23, 2024 06:32
Scorpion1221 added a commit to yybht155/dify that referenced this pull request Dec 24, 2024
* commit 'e88ea71aefd2adca64683ce0cca836df015d0f4f': (91 commits)
  chore/bump version to 0.14.2 (langgenius#12017)
  fix: issue Multiple Paths Between IF/ELSE Branches (langgenius#11646)
  Fix/refactor invoke result handling in question classifier node (langgenius#12015)
  fix: remove json_schema if response format is disabled. (langgenius#12014)
  fix: add UUID validation for tool file ID extraction (langgenius#12011)
  fix: add logging for missing edge mapping in StreamProcessor (langgenius#12008)
  Fix/add retry mechanism to billing service request handling (langgenius#12006)
  Fix/workflow retry log (langgenius#12013)
  fix: add retry feature to code node (langgenius#12005)
  fix: drop useless and wrong code in Account (langgenius#11961)
  fix: improve error handling for file retrieval in AwsS3Storage (langgenius#12002)
  Fix/workflow retry (langgenius#11999)
  feat: add RequestBodyError for invalid request body handling (langgenius#11994)
  fix: Introduce ArrayVariable and update iteration node to handle it (langgenius#12001)
  fix: remove unused credential validation logic in VectorizerProvider (langgenius#12000)
  feat: Warning on invite modal when mail setup is incomplete (langgenius#11809)
  fix: handle broader request exceptions in OAuth process (langgenius#11997)
  fix: Multiple Paths Between IF/ELSE Branches Invalidate Conditions  (langgenius#11544)
  fix: retry node in iteration logs wrong (langgenius#11995)
  fix: remove the unused retry index field (langgenius#11903)
  ...

# Conflicts:
#	web/yarn.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Chatflow, stream chat, click Stop, ERR_INCOMPLETE_CHUNKED_ENCODING
3 participants