Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor BaseVectorIndex delete method #1853

Merged
merged 1 commit into from
Dec 30, 2023

Conversation

waltcow
Copy link
Contributor

@waltcow waltcow commented Dec 29, 2023

vendor index base class should not contain any error type from particular providers

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Dec 29, 2023
Copy link

@barnett-yuxiang barnett-yuxiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazywoola crazywoola merged commit 06d2d8c into langgenius:main Dec 30, 2023
1 check passed
HuberyHuV1 pushed a commit to HuberyHuV1/dify that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants