-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support elasticsearch vector database #3558
feat: support elasticsearch vector database #3558
Conversation
hi @JohnJyong |
Hi there, please run |
Could you add `Setup ElasticSearch' to the CI like Milvus or Quant? @crazywoola |
please fix the pytest and add vdb integration test for it , thanks @miendinh |
added, but need ElasticSearch on CI to run ES tests, plz check @JohnJyong |
CI workflow is set up in the .github/workflows/api-tests.yml @miendinh |
Please test on your local development environment first. |
@miendinh I tried your branch. Celery run failed because the config is missed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall. But several changes are needed for response and actions.
plz check @JohnJyong @crazywoola, thanks. |
We will check it before v0.6.17 |
Co-authored-by: miendinh <[email protected]> Co-authored-by: crazywoola <[email protected]> Co-authored-by: crazywoola <[email protected]>
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Add Elasticsearch vector database for RAG, this feature requires package
elasticsearch==7.15.2
Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Suggested Checklist:
dev/reformat
(backend) andcd web && npx lint-staged
(frontend) to appease the lint godsoptional
I have made corresponding changes to the documentationoptional
I have added tests that prove my fix is effective or that my feature worksoptional
New and existing unit tests pass locally with my changes