Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix indention violations by applying E111 to E117 ruff rules #4925

Merged
merged 6 commits into from
Jun 5, 2024

Conversation

bowenliang123
Copy link
Contributor

@bowenliang123 bowenliang123 commented Jun 4, 2024

Description

  • indention is important for Python code, fixing indention violations by the rules:

    • E111: indentation-with-invalid-multiple
      • violations in api/core/model_runtime/model_providers/bedrock/text_embedding/text_embedding.py,
    • E112: no-indented-block
    • E113: unexpected-indentation
      • violations in api/core/model_runtime/model_providers/baichuan/llm/baichuan_turbo.py
    • E115: no-indented-block-comment
    • E116: unexpected-indentation-comment
    • E117: over-indented
    • related docs for the rules: https://docs.astral.sh/ruff/rules/#error-e
  • remove unused noqa directive by applying RUF100 rule

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • TODO

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. 🐍 python labels Jun 4, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 5, 2024
@crazywoola crazywoola merged commit f32b440 into langgenius:main Jun 5, 2024
5 checks passed
@bowenliang123 bowenliang123 deleted the ruff-indention branch June 5, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants