Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename vdb tests for PGVector and PGvectoRS #4973

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

bowenliang123
Copy link
Contributor

@bowenliang123 bowenliang123 commented Jun 5, 2024

Description

  • to avoid warning messages in CI tests, by removing Test prefix in vdb tests' class name:
api/tests/integration_tests/vdb/pgvecto_rs/test_pgvecto_rs.py:9
  /home/runner/work/dify/dify/api/tests/integration_tests/vdb/pgvecto_rs/test_pgvecto_rs.py:9: PytestCollectionWarning: cannot collect test class 'TestPgvectoRSVector' because it has a __init__ constructor (from: tests/integration_tests/vdb/pgvecto_rs/test_pgvecto_rs.py)
    class TestPgvectoRSVector(AbstractVectorTest):
api/tests/integration_tests/vdb/pgvector/test_pgvector.py:10
  /home/runner/work/dify/dify/api/tests/integration_tests/vdb/pgvector/test_pgvector.py:10: PytestCollectionWarning: cannot collect test class 'TestPGVector' because it has a __init__ constructor (from: tests/integration_tests/vdb/pgvector/test_pgvector.py)
    class TestPGVector(AbstractVectorTest):

Fixes # (issue)

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • TODO

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jun 5, 2024
@takatost takatost requested a review from JohnJyong June 5, 2024 16:38
Copy link
Member

@crazywoola crazywoola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 5, 2024
@crazywoola crazywoola merged commit 7fa735a into langgenius:main Jun 5, 2024
5 checks passed
@bowenliang123 bowenliang123 deleted the vdb-test-pgnames branch June 5, 2024 23:25
dengpeng pushed a commit to dengpeng/dify that referenced this pull request Jun 16, 2024
HuberyHuV1 pushed a commit to HuberyHuV1/dify that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants