Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 fix docker-compose ssrf_proxy service WARNING: You should probably remove '::/0' from the ACL named 'all' #5005

Merged
merged 1 commit into from
Jun 9, 2024

Conversation

takuya-o
Copy link
Contributor

@takuya-o takuya-o commented Jun 6, 2024

🔧 fix(squid.conf): change ACL name from 'all' to 'src_all' to avoid conflict

Renamed the ACL name from 'all' to 'src_all'. This avoids conflicts with predefined keywords. It fixed "WARNING: You should probably remove '::/0' from the ACL named 'all'"

Description

The ssrf_proxy serivce in docker-compose.yaml occrured waring.

ssrf_proxy-1  | 2024/06/06 16:47:51| Processing Configuration File: /etc/squid/squid.conf (depth 0)
ssrf_proxy-1  | 2024/06/06 16:47:51| WARNING: (B) '::/0' is a subnetwork of (A) '::/0'
ssrf_proxy-1  | 2024/06/06 16:47:51| WARNING: because of this '::/0' is ignored to keep splay tree searching predictable
ssrf_proxy-1  | 2024/06/06 16:47:51| WARNING: You should probably remove '::/0' from the ACL named 'all'
ssrf_proxy-1  | 2024/06/06 16:47:51| Created PID file (/run/squid.pid)

This is because, ACL 'all' is predefined in squid.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

I restarted and confirmed that the warning was gone.

$ docker compose up ssrf_proxy 
Attaching to ssrf_proxy-1
ssrf_proxy-1  | 2024/06/06 16:50:12| Processing Configuration File: /etc/squid/squid.conf (depth 0)
ssrf_proxy-1  | 2024/06/06 16:50:12| Created PID file (/run/squid.pid)
ssrf_proxy-1  | 2024/06/06 16:50:12| Set Current Directory to /var/spool/squid
ssrf_proxy-1  | 2024/06/06 16:50:12| Creating missing swap directories

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes

…onflict

Renamed the ACL name from 'all' to 'src_all'. This avoids conflicts with predefined keywords.
It fixed "WARNING: You should probably remove '::/0' from the ACL named 'all'"
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🐞 bug Something isn't working labels Jun 6, 2024
@crazywoola crazywoola requested a review from Yeuoly June 7, 2024 00:27
Copy link
Collaborator

@Yeuoly Yeuoly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 9, 2024
@Yeuoly Yeuoly merged commit 308ce66 into langgenius:main Jun 9, 2024
5 checks passed
dengpeng pushed a commit to dengpeng/dify that referenced this pull request Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants