Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use Poetry as default build system for dependency installation in CI jobs #5088

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

bowenliang123
Copy link
Contributor

@bowenliang123 bowenliang123 commented Jun 11, 2024

Description

  • use poetry for Python dependencies installation in CI jobs
  • managing dependencies in categories
    • default
    • dev (for running tests)
    • lint (newly added)
  • saving 50% execution time (without available cache) and 90% (with cache) for installing dependencies
  • move API Tests names from pip-based to poetry-based tests, as for required workflow jobs

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • TODO

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes

@bowenliang123 bowenliang123 changed the title build: apply poetry in github actions and fix the peotry action position build: apply poetry in github actions Jun 11, 2024
@bowenliang123 bowenliang123 marked this pull request as ready for review June 11, 2024 23:29
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. 🐍 python labels Jun 11, 2024
@bowenliang123 bowenliang123 changed the title build: apply poetry in github actions build: use poetry as default build system for dependency installation in github actions Jun 11, 2024
@bowenliang123 bowenliang123 changed the title build: use poetry as default build system for dependency installation in github actions build: use Poetry as default build system for dependency installation in github actions Jun 11, 2024
@bowenliang123
Copy link
Contributor Author

cc @takatost

@bowenliang123 bowenliang123 changed the title build: use Poetry as default build system for dependency installation in github actions build: use Poetry as default build system for dependency installation in CI jobs Jun 11, 2024
Copy link
Collaborator

@takatost takatost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 12, 2024
@takatost takatost merged commit 25b0a97 into langgenius:main Jun 12, 2024
8 checks passed
@bowenliang123 bowenliang123 deleted the poetry-actions branch June 12, 2024 06:46
@takatost takatost mentioned this pull request Jun 14, 2024
dengpeng pushed a commit to dengpeng/dify that referenced this pull request Jun 16, 2024
HuberyHuV1 pushed a commit to HuberyHuV1/dify that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants