feat: add flask upgrade-db command for running db upgrade with redis lock
#5333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:M
bowenliang123
changed the title
flask db-migrate command for running db migraition with redis lock supportflask db-migrate command for running db migraition with redis lock support
|
it could be one of long-awaited features for Docker users relying on auto db migration., as fixing a bug in concurrent running db migration concurrently. If you have any better suggestion for the command name, fell free to raise it. |
bowenliang123
force-pushed
the
migrate-py
branch
from
19b3cf2 to
52fac6e
Compare
bowenliang123
changed the title
flask db-migrate command for running db migraition with redis lock supportflask upgrade-db command for running db upgrade with redis lock support
bowenliang123
changed the title
flask upgrade-db command for running db upgrade with redis lock supportflask upgrade-db command for running db upgrade with redis lock
crazywoola
approved these changes
Jun 18, 2024
ZhouhaoJiang
added a commit
that referenced
this pull request
Jun 18, 2024
* refs/heads/feat/llm-ops-tracing: (24 commits) feat: change TraceAppConfigApi request type patch chore: set build system to Poetry and remove unnecessary settings with package mode disabled (#5263) feat: add `flask upgrade-db` command for running db upgrade with redis lock (#5333) fix: wrong token usage in iteration node for streaming result (#5336) feat: change table struct feat: update trace table feat: add remove tracing app feat: add llm ops tracing feat: add Novita AI image generation tool, implemented model search, text-to-image and create tile functionalities (#5308) feat: support Latex (#5001) fix: workflow results in FAIL status due to null reference error (#5332) chore: update llm.py (#5335) fix: extract params by function calling for models supporting tool call (#5334) Update and fix the model param of Deepseek (#5329) fix: allow special characters in email (#5327) fix: got unknown type of prompt message in multi-round ReAct agent chat (#5245) chore(core/workflow/utils/variable_template_parser): Refactor VariableTemplateParser class for better readability and maintainability. (#5328) fix(core/workflow): Handle special values in node run result outputs (#5321) Add bedrock command r models (#4521) add the filename length limit (#5326) ...
HuberyHuV1
pushed a commit
to HuberyHuV1/dify
that referenced
this pull request
Jul 22, 2024
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MIGRATION_ENABLEDenv set totrue,flask db upgradecommand will be executed concurrently in multiple api or worker instances when starting-up, which is lack of locking and will cause hanging status and unresolvable consequences leading the service failingflask upgrade-dbcommand to make sure the lock is acquired from Redis before running the db migrationsFixes # (issue)
Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
flask db-migratecommand with redisSuggested Checklist:
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint godsoptionalI have made corresponding changes to the documentationoptionalI have added tests that prove my fix is effective or that my feature worksoptionalNew and existing unit tests pass locally with my changes