Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/6615 40 varchar limit on model name #6623

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

crazywoola
Copy link
Member

@crazywoola crazywoola commented Jul 24, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. Close issue syntax: Fixes #<issue number>, see documentation for more details.

Fixes #6615

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@crazywoola crazywoola linked an issue Jul 24, 2024 that may be closed by this pull request
5 tasks
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jul 24, 2024
@crazywoola crazywoola requested a review from laipz8200 July 24, 2024 08:09
@dosubot dosubot bot added the 🐞 bug Something isn't working label Jul 24, 2024
Copy link
Member

@laipz8200 laipz8200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 24, 2024
@laipz8200 laipz8200 merged commit f324374 into main Jul 24, 2024
9 checks passed
@laipz8200 laipz8200 deleted the fix/6615-40-varchar-limit-on-model-name branch July 24, 2024 08:23
@mbbyn
Copy link

mbbyn commented Jul 24, 2024

@crazywoola the column causing the problems is model_name as oppose to provider_name.

I have pulled main to test, and was facing the same issue.

@mbbyn
Copy link

mbbyn commented Jul 24, 2024

Also noticed that the table name is embeddings, but in the reported issue the problematic table is dataset_collection_bindings. Perhaps the size changes are required in multiple places?

cuiks pushed a commit to cuiks/dify that referenced this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

40 VARCHAR Limit on Model Name
3 participants