Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dep: support for Python 3.12 #6771

Merged
merged 4 commits into from
Aug 2, 2024
Merged

Conversation

bowenliang123
Copy link
Contributor

@bowenliang123 bowenliang123 commented Jul 29, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 29, 2024
@bowenliang123 bowenliang123 marked this pull request as draft July 29, 2024 12:19
@dosubot dosubot bot added dependencies Pull requests that update a dependency file 🐍 python labels Jul 29, 2024
@bowenliang123 bowenliang123 marked this pull request as ready for review July 29, 2024 12:52
@bowenliang123 bowenliang123 changed the title run tests on Python 3.12 test: support Python 3.12 Jul 29, 2024
@bowenliang123 bowenliang123 changed the title test: support Python 3.12 dep: support Python 3.12 Jul 29, 2024
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. size:S This PR changes 10-29 lines, ignoring generated files. labels Jul 29, 2024
@bowenliang123
Copy link
Contributor Author

cc @takatost @JohnJyong

@bowenliang123 bowenliang123 force-pushed the python312 branch 3 times, most recently from 3279eaf to a0bf1b4 Compare July 30, 2024 02:45
crazywoola
crazywoola previously approved these changes Jul 30, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 30, 2024
@takatost takatost requested review from Yeuoly and JohnJyong July 31, 2024 05:54
@takatost
Copy link
Collaborator

@Yeuoly Pls make sure that the dependencies on gmpy2 are functioning correctly.
@JohnJyong Pls make sure that the dependencies on grpcio are functioning correctly.

Yeuoly
Yeuoly previously approved these changes Jul 31, 2024
Copy link
Collaborator

@Yeuoly Yeuoly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

crazywoola
crazywoola previously approved these changes Aug 2, 2024
@bowenliang123 bowenliang123 dismissed stale reviews from crazywoola and Yeuoly via 93a7769 August 2, 2024 13:02
@bowenliang123 bowenliang123 changed the title dep: support Python 3.12 dep: support for Python 3.12 Aug 2, 2024
@bowenliang123
Copy link
Contributor Author

Conflicts resolved. cc @crazywoola

@bowenliang123 bowenliang123 marked this pull request as draft August 2, 2024 13:03
@bowenliang123 bowenliang123 marked this pull request as ready for review August 2, 2024 13:13
@crazywoola crazywoola merged commit 70283f5 into langgenius:main Aug 2, 2024
7 checks passed
@bowenliang123 bowenliang123 deleted the python312 branch August 2, 2024 13:14
@takatost takatost mentioned this pull request Aug 5, 2024
cuiks pushed a commit to cuiks/dify that referenced this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants