Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update SQLAlchemy configuration with custom naming convention #6854

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

laipz8200
Copy link
Member

@laipz8200 laipz8200 commented Jul 31, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

This pull request introduces the following enhancements:

  1. Ensures that flask db migrate generates indices and primary keys using the configured names.
  2. Improves the readability of the generated migration file names, making them more meaningful for users.

Fixes

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jul 31, 2024
@laipz8200 laipz8200 requested review from takatost and crazywoola July 31, 2024 19:25
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 1, 2024
@laipz8200 laipz8200 merged commit feb4576 into main Aug 1, 2024
9 checks passed
@laipz8200 laipz8200 deleted the feat/apply-format-to-db-index-name branch August 1, 2024 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants