Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api/workflow): Add Conversation.dialogue_count #7275

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

laipz8200
Copy link
Member

@laipz8200 laipz8200 commented Aug 14, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

Description

This PR introduces a new system variable, dialogue_count, within the chat flow to track the number of rounds in the current conversation.

Screen.Recording.2024-08-14.at.11.46.06.PM.mov

Close #7278

Implementation Details:

  • A new context variable, workflow_variable_pool, has been created and integrated into the runner and pipeline to support this functionality.
  • The SystemVariable enum has been relocated to workflow/enums to prevent circular imports.

Important Note:

  • The implementation is not thread-safe.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. 🌊 feat:workflow Workflow related stuff. labels Aug 14, 2024
@laipz8200 laipz8200 marked this pull request as draft August 14, 2024 15:52
@laipz8200 laipz8200 marked this pull request as ready for review August 14, 2024 16:25
@laipz8200 laipz8200 requested a review from crazywoola August 14, 2024 16:25
Copy link
Member

@crazywoola crazywoola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 15, 2024
@laipz8200 laipz8200 merged commit 32dc963 into main Aug 15, 2024
10 checks passed
@laipz8200 laipz8200 deleted the feat/add-conversation-dialogue-count branch August 15, 2024 02:53
ZhouhaoJiang added a commit that referenced this pull request Aug 16, 2024
* main: (107 commits)
  Fix: missing default value of type array object in conversation variable modal (#7309)
  fix: inability-to-add-node-and-change-the-edge (#7303)
  fix(api/services/app_dsl_service.py): Add conversation variables. (#7304)
  Feat/7023 dify editor can resize the image (#7296)
  fix(api/core/app/segments/segments.py): Fix file to markdown. (#7293)
  feat: support pinning, including, and excluding for Model Providers and Tools (#7283)
  chore(api): Introduce Ruff Formatter. (#7291)
  chore(api/core): Improve FileVar's type hint and imports. (#7290)
  feat: support OPENAI json_schema (#7258)
  feat: add chatgpt-4o-latest (#7289)
  feat(api/workflow): Add `Conversation.dialogue_count` (#7275)
  fix: can not input param value in tool test modal (#7281)
  Add jp translation for variable aggregator (#7277)
  fix: #7222 docstrings (#7276)
  fix ja-JP translation of secret values (#7279)
  fix: typo in upstage/llm/_position.yaml (#7286)
  fix: missed rerank_mode when convert to DatasetEntity (#7269)
  Fix SQL parser Error in MyScale vdb. (#7255)
  chore: allow download audio/video through HTTP node (#7224)
  Fix: support hide env & conversation var in prompt editor (#7256)
  ...
cuiks pushed a commit to cuiks/dify that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌊 feat:workflow Workflow related stuff. lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A new system variable, dialogue_count, to record the number of conversation rounds.
2 participants