Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ops trace add llm model #7306

Merged
merged 4 commits into from
Sep 4, 2024
Merged

feat: ops trace add llm model #7306

merged 4 commits into from
Sep 4, 2024

Conversation

ZhouhaoJiang
Copy link
Collaborator

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. Close issue syntax: Fixes #<issue number>, see documentation for more details.

update workflow trace model name and provider
CleanShot 2024-08-15 at 16 31 40@2x

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@ZhouhaoJiang ZhouhaoJiang marked this pull request as ready for review August 15, 2024 08:33
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. 🌊 feat:workflow Workflow related stuff. labels Aug 15, 2024
@crazywoola crazywoola requested a review from GarfieldDai August 16, 2024 08:55
GarfieldDai
GarfieldDai previously approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@GarfieldDai GarfieldDai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 4, 2024
@ZhouhaoJiang
Merge branch 'refs/heads/main' into feat/ops-treace-add-llm-model
a7543d0 
* refs/heads/main: (219 commits)
  Revert "fix: an issue of keyword search feature in application log list" (#7949)
  chore: #7943 i18n (#7948)
  fix(api): Code-Based Extension cause error on position map sorting (#7934)
  Chore/add roadmap (#7943)
  Chore/add default step 1x url (#7933)
  fix rerank model value is empty string (#7937)
  chore: #7603 i18n (#7931)
  Fix/segment create with api (#7928)
  improve the notion table extract (#7925)
  fix: frontend handle sometimes server not generate the wrong follow up data struct (#7916)
  feat: support auto generate i18n translate (#6964)
  chore: Update versions to 0.7.3 (#7895)
  chore(Dockerfile): Bump expat to 2.6.2-2 (#7904)
  fix: correct typo in the setting screen (#7897)
  feat: allow users to use the app icon as the answer icon (#7888)
  ignore linked images when image id is none (#7890)
  Add Russian language (#7860)
  fix: fixed typo on loading reranking_mode (#7887)
  Add perplexity search as a new tool (#7861)
  fix: glm models prices and max_tokens correction (#7882)
  ...

# Conflicts:
#	api/core/workflow/nodes/question_classifier/question_classifier_node.py
GarfieldDai
GarfieldDai approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@GarfieldDai GarfieldDai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GarfieldDai GarfieldDai merged commit fee4d3f into main Sep 4, 2024
9 checks passed
@GarfieldDai GarfieldDai deleted the feat/ops-treace-add-llm-model branch September 4, 2024 02:39
mehrajagdish pushed a commit to Sbazar-GmbH/dify that referenced this pull request Sep 6, 2024
@ZhouhaoJiang @mehrajagdish
feat: ops trace add llm model (langgenius#7306)
0991434
@ZhouhaoJiang ZhouhaoJiang mentioned this pull request Sep 22, 2024
Closed
5 tasks
cuiks pushed a commit to cuiks/dify that referenced this pull request Sep 26, 2024
@ZhouhaoJiang @cuiks
feat: ops trace add llm model (langgenius#7306)
1215996
lau-td pushed a commit to heydevs-io/dify that referenced this pull request Oct 23, 2024
@ZhouhaoJiang @lau-td
feat: ops trace add llm model (langgenius#7306)
a56b005
@luca1024-web
Copy link

@ZhouhaoJiang
I'm using the latest version but still have this problem. It's basically the same problem as this description, except that the charges just won't show up. Can you help me?
（Langfuse:v2.86.0
Dify:0.10.2）
image
image

@ZhouhaoJiang
Copy link
Collaborator Author

@ZhouhaoJiang I'm using the latest version but still have this problem. It's basically the same problem as this description, except that the charges just won't show up. Can you help me?我使用的是最新版本，但仍然存在此问题。这与此描述基本相同，只是费用不会显示。你可以帮我吗？ （Langfuse:v2.86.0 （朗福斯：v2.86.0 Dify:0.10.2） Dify：0.10.2） image image

You can check the langfuse documentation to see if it supports automatic estimation of the consumption of the model you are using

@luca1024-web
Copy link

@ZhouhaoJiang我正在使用最新版本，但仍然有这个问题。这基本上与此描述的问题相同，只是费用不会显示。你能帮我吗？我使用的是最新版本，但仍然存在此问题。这与此描述基本相同，只是费用不会显示。你可以帮我吗？ （Langfuse:v2.86.0 （朗福斯：v2.0） 86.0 定义：0.10.2） 定义：0.10.2）图像 图像

你可以查看 langfuse 文档，看看它是否支持自动估算你正在使用的模型的消耗

Thank you for your reply. I have reopened a bug with a detailed description, including the integrated 4o-mini, which also has the same problem. I look forward to your reply again.

idonotknow pushed a commit to AceDataCloud/Dify that referenced this pull request Nov 16, 2024
@ZhouhaoJiang @JunXu01
feat: ops trace add llm model (langgenius#7306)
d97fad0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GarfieldDai GarfieldDai GarfieldDai approved these changes

Assignees
No one assigned
Labels
🌊 feat:workflow Workflow related stuff. lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZhouhaoJiang @luca1024-web @GarfieldDai