Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: app icon in app_dsl_service.py #7507

Closed

Conversation

ZuzooVn
Copy link
Contributor

@ZuzooVn ZuzooVn commented Aug 21, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🐍 python 🐞 bug Something isn't working labels Aug 21, 2024
@crazywoola
Copy link
Member

@xuzuodong Please take a look at this as well.

@xuzuodong
Copy link
Contributor

This was done intentionally by me during the development of #7196. The exported DSL file might be imported into other distributions, for example, a DSL file exported in cloud.dify.ai might be imported into a user’s self-deployed version of Dify. In such cases, the imported images will be invalid.

@crazywoola crazywoola closed this Aug 22, 2024
@ZuzooVn ZuzooVn deleted the fix-app-icon-app_dsl_service.py branch August 22, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants