Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missed modifications of <AppIcon /> #7512

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

xuzuodong
Copy link
Contributor

@xuzuodong xuzuodong commented Aug 21, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

This PR is based on #7196 and supplements some missed modifications throughout the project when adding new features.

  1. Navgitaor
image
  1. Web chat app config panel
image
  1. Embedded chat app config panel
image
  1. When creating tool from workflow app whose icon is an image, use default emoji as initial state
2024-08-22.14.53.00.mov
  1. Fixed several type errors

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@xuzuodong xuzuodong marked this pull request as ready for review August 22, 2024 05:28
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. ☕️ typescript Pull request that update TypeScript code. 🐞 bug Something isn't working labels Aug 22, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 22, 2024
@crazywoola crazywoola merged commit 60ef7ba into langgenius:main Aug 22, 2024
3 checks passed
@xuzuodong xuzuodong deleted the fix/image-icon-missing branch August 22, 2024 08:14
cuiks pushed a commit to cuiks/dify that referenced this pull request Sep 2, 2024
idonotknow pushed a commit to AceDataCloud/Dify that referenced this pull request Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files. ☕️ typescript Pull request that update TypeScript code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants