Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup and rearrange unclassified configs into feature config groups #7586

Merged
merged 11 commits into from
Aug 23, 2024

Conversation

bowenliang123
Copy link
Contributor

@bowenliang123 bowenliang123 commented Aug 23, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

  • rearrange unclassified configs of DifyConfig in proper feature groups
  • make configs configurable in code execution details and HTTP requesting, with data type checks
  • avoid abused usage of @computed_field for display messages, which is week in reliability and misuse of configs:
    • HTTP_REQUEST_NODE_READABLE_MAX_BINARY_SIZE
    • HTTP_REQUEST_NODE_MAX_TEXT_SIZE
  • removing unused config:
    • OUTPUT_MODERATION_BUFFER_SIZE

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@bowenliang123 bowenliang123 changed the title [WIP] chore: rearrange unclassified configs in DifyConfig chore: cleanup and rearrange unclassified configs in proper feature config groups Aug 23, 2024
@bowenliang123 bowenliang123 marked this pull request as ready for review August 23, 2024 14:19
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. 💪 enhancement New feature or request labels Aug 23, 2024
@bowenliang123
Copy link
Contributor Author

cc @laipz8200 @takatost

@bowenliang123 bowenliang123 changed the title chore: cleanup and rearrange unclassified configs in proper feature config groups chore: cleanup and rearrange unclassified configs into feature config groups Aug 23, 2024
@laipz8200 laipz8200 self-requested a review August 23, 2024 14:28
Copy link
Member

@laipz8200 laipz8200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 23, 2024
@laipz8200 laipz8200 merged commit 3ace01c into langgenius:main Aug 23, 2024
6 checks passed
@laipz8200
Copy link
Member

Hi @bowenliang123. This would be a great opportunity to apply the Ruff Formatter within the config/ directory. Would you be interested in implementing this change?

@bowenliang123 bowenliang123 deleted the config-improve branch August 23, 2024 15:07
@bowenliang123
Copy link
Contributor Author

bowenliang123 commented Aug 23, 2024

Hi @bowenliang123. This would be a great opportunity to apply the Ruff Formatter within the config/ directory. Would you be interested in implementing this change?

Sure. That goes with #7590 for the configs, #7591 for the tests and #7592 for the db migrations.

@laipz8200
Copy link
Member

Hi @bowenliang123. This would be a great opportunity to apply the Ruff Formatter within the config/ directory. Would you be interested in implementing this change?

Sure. That goes with #7590 for the configs, #7591 for the tests and #7592 for the db migrations.

Awesome! Thank you for doing these!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants