Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: deprecate gte-Qwen2-7B-instruct embedding model #8866

Merged
merged 1 commit into from
Sep 28, 2024
Merged

feat: deprecate gte-Qwen2-7B-instruct embedding model #8866

merged 1 commit into from
Sep 28, 2024

Conversation

hwzhuhao
Copy link
Contributor

@hwzhuhao hwzhuhao commented Sep 28, 2024 •
edited
Loading

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

  1. deprecate gte-Qwen2-7B-instruct embedding model
  2. Rearrange the sequence of models in the _position file under the llm directory.
  3. Add a _position file for the text-embedding model

image

Fixes #8867

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. ⚙️ feat:model-runtime labels Sep 28, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 28, 2024
@crazywoola crazywoola merged commit 850492d into langgenius:main Sep 28, 2024
6 checks passed
ZhouhaoJiang added a commit that referenced this pull request Sep 29, 2024
@ZhouhaoJiang
Merge branch 'main' into feat/new-login
cd88f27 
* main: (77 commits)
  feat: add voyage ai as a new model provider (#8747)
  docs: add english versions for the files customizable_model_scale_out and predefined_model_scale_out (#8871)
  fix: #8843 event: tts_message_end always return in api streaming resp… (#8846)
  Add Jamba and Llama3.2 model support (#8878)
  fix(workflow): update tagging logic in GitHub Actions (#8882)
  chore: bump ruff to 0.6.8 for fixing violation in SIM910 (#8869)
  refactor: update Callback to an abstract class (#8868)
  feat: deprecate gte-Qwen2-7B-instruct embedding model (#8866)
  feat: add internlm2.5-20b and qwen2.5-coder-7b model (#8862)
  fix: customize model credentials were invalid despite the provider credentials being active (#8864)
  fix: update qwen2.5-coder-7b model name (#8861)
  fix(workflow/nodes/knowledge-retrieval/use-config): Preserve rerankin… (#8842)
  chore: fix wrong VectorType match case (#8857)
  feat: add min-connection and max-connection for pgvector (#8841)
  feat(Tools): add feishu tools (#8800)
  fix: delete harm catalog settings for gemini (#8829)
  Add Llama3.2 models in Groq provider (#8831)
  feat: deprecate mistral model for siliconflow (#8828)
  fix: AnalyticdbVector retrieval scores (#8803)
  fix: close log status option raise error (#8826)
  ...
ZhouhaoJiang added a commit that referenced this pull request Sep 29, 2024
@ZhouhaoJiang
Merge branch 'feat/new-login' into test/new-login-testing
a62b8ff 
* feat/new-login: (79 commits)
  feat: add setup only
  feat: remove self-host
  feat: add voyage ai as a new model provider (#8747)
  docs: add english versions for the files customizable_model_scale_out and predefined_model_scale_out (#8871)
  fix: #8843 event: tts_message_end always return in api streaming resp… (#8846)
  Add Jamba and Llama3.2 model support (#8878)
  fix(workflow): update tagging logic in GitHub Actions (#8882)
  chore: bump ruff to 0.6.8 for fixing violation in SIM910 (#8869)
  refactor: update Callback to an abstract class (#8868)
  feat: deprecate gte-Qwen2-7B-instruct embedding model (#8866)
  feat: add internlm2.5-20b and qwen2.5-coder-7b model (#8862)
  fix: customize model credentials were invalid despite the provider credentials being active (#8864)
  fix: update qwen2.5-coder-7b model name (#8861)
  fix(workflow/nodes/knowledge-retrieval/use-config): Preserve rerankin… (#8842)
  chore: fix wrong VectorType match case (#8857)
  feat: add min-connection and max-connection for pgvector (#8841)
  feat(Tools): add feishu tools (#8800)
  fix: delete harm catalog settings for gemini (#8829)
  Add Llama3.2 models in Groq provider (#8831)
  feat: deprecate mistral model for siliconflow (#8828)
  ...
@hwzhuhao hwzhuhao deleted the feat/deprecate-gte-Qwen2-7B branch October 6, 2024 00:36
cuiks pushed a commit to cuiks/dify that referenced this pull request Oct 8, 2024
@hwzhuhao @cuiks
feat: deprecate gte-Qwen2-7B-instruct embedding model (langgenius#8866)
f8834e4
lau-td pushed a commit to heydevs-io/dify that referenced this pull request Oct 23, 2024
@hwzhuhao @lau-td
feat: deprecate gte-Qwen2-7B-instruct embedding model (langgenius#8866)
9fdeadc
idonotknow pushed a commit to AceDataCloud/Dify that referenced this pull request Nov 16, 2024
@hwzhuhao @JunXu01
feat: deprecate gte-Qwen2-7B-instruct embedding model (langgenius#8866)
072d8f1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazywoola crazywoola crazywoola approved these changes

Assignees
No one assigned
Labels
⚙️ feat:model-runtime lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deprecate gte-Qwen2-7B-instruct embedding in perfxcloud
2 participants
@hwzhuhao @crazywoola