Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

external knowledge api #8913

Merged
merged 65 commits into from
Sep 30, 2024
Merged

external knowledge api #8913

merged 65 commits into from
Sep 30, 2024

Conversation

JohnJyong
Copy link
Contributor

@JohnJyong JohnJyong commented Sep 30, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

External Knowledge API:
By providing API endpoint, API key, external knowledge ID, the user can effectively connect to the knowledge base of third-party products.
Support calling the retrieval interface to retrieve and recall external knowledge based on the user's query.
Support integrating external knowledge bases within Dify applications.

Fixes

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

JohnJyong and others added 30 commits August 20, 2024 11:13
# Conflicts:
#	api/controllers/console/auth/data_source_oauth.py
# Conflicts:
#	api/core/rag/datasource/retrieval_service.py
#	api/models/dataset.py
#	api/services/dataset_service.py
# Conflicts:
#	api/core/rag/retrieval/dataset_retrieval.py
@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Sep 30, 2024
@JohnJyong JohnJyong requested a review from takatost September 30, 2024 06:50
@dosubot dosubot bot added 💪 enhancement New feature or request 📚 feat:datasource Data sources like web, Notion, Logseq, Lark, Docs labels Sep 30, 2024
@JohnJyong JohnJyong requested review from iamjoel and zxhlyh and removed request for iamjoel September 30, 2024 06:51
zxhlyh
zxhlyh previously approved these changes Sep 30, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 30, 2024
takatost
takatost previously approved these changes Sep 30, 2024
takatost
takatost previously approved these changes Sep 30, 2024
@JohnJyong JohnJyong merged commit 9d221a5 into main Sep 30, 2024
11 checks passed
@JohnJyong JohnJyong deleted the feat/external-knowledge-api branch September 30, 2024 07:38
cuiks pushed a commit to cuiks/dify that referenced this pull request Oct 8, 2024
lau-td pushed a commit to heydevs-io/dify that referenced this pull request Oct 23, 2024
idonotknow pushed a commit to AceDataCloud/Dify that referenced this pull request Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 enhancement New feature or request 📚 feat:datasource Data sources like web, Notion, Logseq, Lark, Docs lgtm This PR has been approved by a maintainer size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants