-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: assembling the app features in modular way #9129
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9684b1c
to
44af529
Compare
3d832f8
to
7786005
Compare
bd349cd
to
013929f
Compare
12 tasks
crazywoola
previously approved these changes
Oct 29, 2024
Please resolve the conflicts, thanks |
c48b402
to
8145ea6
Compare
It's now ready for review again, with all conflicts resolved and changes refactored. cc @laipz8200 @crazywoola |
612a11b
to
dbd2b09
Compare
58e08a4
to
542cdb3
Compare
Signed-off-by: -LAN- <[email protected]>
Signed-off-by: -LAN- <[email protected]>
Signed-off-by: -LAN- <[email protected]>
bowenliang123
commented
Nov 29, 2024
Signed-off-by: -LAN- <[email protected]>
laipz8200
reviewed
Nov 29, 2024
laipz8200
approved these changes
Nov 30, 2024
Great! Another step forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
💪 enhancement
New feature or request
lgtm
This PR has been approved by a maintainer
size:XL
This PR changes 500-999 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Important
Please review the checklist below before submitting your pull request.
dev/reformat
(backend) andcd web && npx lint-staged
(frontend) to appease the lint godsDescription
app.py
in modular way, by extending features with extensionsDifyApp
class as first class member for decouplingType of Change
Testing Instructions
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration