Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ext_redis.py support redis clusters --- Fixes #9538 #9789

Merged
merged 13 commits into from
Nov 20, 2024

Conversation

liuhaoran1212
Copy link
Contributor

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

This submission has enabled support for starting Redis clusters in the ext_redis.py
Fixes #9538

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Oct 24, 2024
@crazywoola crazywoola requested a review from laipz8200 October 24, 2024 09:41
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Oct 24, 2024
@bowenliang123
Copy link
Contributor

LGTM overall. cc @takatost @laipz8200

@liuhaoran1212
Copy link
Contributor Author

@bowenliang123 @takatost @laipz8200 Can the code be merged into the main branch? Please confirm, thanks.

@laipz8200 laipz8200 assigned laipz8200 and unassigned laipz8200 Nov 3, 2024
@laipz8200
Copy link
Member

Please make sure the CI passes.

@liuhaoran1212
Copy link
Contributor Author

There can not see CI is running, only display "2 workflows awaiting approval" , Why? @laipz8200 @bowenliang123

@bowenliang123
Copy link
Contributor

Because this is your first ever PR in this repo, all workflows are executed only when the maintainer approves the runs. You may need a hand from @laipz8200 @crazywoola . Or you may test it locally and raise your screenshot evidence for passing the tests.

@liuhaoran1212
Copy link
Contributor Author

CI has passed, looking forward to merging into main, thanks. @laipz8200

@laipz8200
Copy link
Member

Please also add the new environment variables to .env.example files located under api/ and docker/.

Copy link
Member

@laipz8200 laipz8200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sync with the main branch before the merge.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 20, 2024
@laipz8200 laipz8200 merged commit 8ff65ab into langgenius:main Nov 20, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Redis Cluster to ext_redis.py
3 participants