-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ext_redis.py support redis clusters --- Fixes #9538 #9789
Conversation
Signed-off-by: root <[email protected]>
Signed-off-by: root <[email protected]>
Signed-off-by: root <[email protected]>
LGTM overall. cc @takatost @laipz8200 |
Okay Co-authored-by: Bowen Liang <[email protected]>
Signed-off-by: root <[email protected]>
@bowenliang123 @takatost @laipz8200 Can the code be merged into the main branch? Please confirm, thanks. |
Please make sure the CI passes. |
There can not see CI is running, only display "2 workflows awaiting approval" , Why? @laipz8200 @bowenliang123 |
Because this is your first ever PR in this repo, all workflows are executed only when the maintainer approves the runs. You may need a hand from @laipz8200 @crazywoola . Or you may test it locally and raise your screenshot evidence for passing the tests. |
Signed-off-by: root <[email protected]>
Signed-off-by: root <[email protected]>
Signed-off-by: root <[email protected]>
CI has passed, looking forward to merging into main, thanks. @laipz8200 |
Please also add the new environment variables to |
Signed-off-by: root <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please sync with the main branch before the merge.
Checklist:
Important
Please review the checklist below before submitting your pull request.
dev/reformat
(backend) andcd web && npx lint-staged
(frontend) to appease the lint godsDescription
This submission has enabled support for starting Redis clusters in the ext_redis.py
Fixes #9538
Type of Change
Testing Instructions
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration