Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tidb on qdrant type #9831

Merged
merged 25 commits into from
Oct 25, 2024
Merged

add tidb on qdrant type #9831

merged 25 commits into from
Oct 25, 2024

Conversation

JohnJyong
Copy link
Contributor

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

support TIDB on qdrant vector type
Fixes

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

JohnJyong and others added 23 commits July 30, 2024 17:48
# Conflicts:
#	api/controllers/console/datasets/datasets.py
#	api/core/rag/datasource/vdb/vector_type.py
# Conflicts:
#	api/extensions/ext_celery.py
# Conflicts:
#	api/configs/feature/__init__.py
#	api/configs/middleware/__init__.py
#	api/controllers/console/datasets/datasets.py
#	api/core/rag/datasource/vdb/vector_type.py
# Conflicts:
#	api/configs/middleware/__init__.py
#	api/controllers/console/datasets/datasets.py
#	api/core/rag/datasource/vdb/vector_factory.py
#	api/core/rag/datasource/vdb/vector_type.py
#	api/services/auth/api_key_auth_factory.py
#	api/tests/integration_tests/workflow/nodes/__mock/http.py
#	web/app/components/datasets/create/website/index.tsx
#	web/app/components/datasets/create/website/jina-reader/index.tsx
#	web/app/components/datasets/create/website/jina-reader/options.tsx
#	web/app/components/header/account-setting/data-source-page/data-source-website/config-jina-reader-modal.tsx
#	web/i18n/en-US/dataset-creation.ts
#	web/service/datasets.ts
# Conflicts:
#	api/configs/middleware/__init__.py
#	api/core/rag/datasource/vdb/vector_factory.py
#	api/core/rag/datasource/vdb/vector_type.py
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. 👻 feat:rag Embedding related issue, like qdrant, weaviate, milvus, vector database. labels Oct 25, 2024
@JohnJyong JohnJyong requested a review from takatost October 25, 2024 03:21
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 25, 2024
@JohnJyong JohnJyong merged commit 18106a4 into main Oct 25, 2024
11 checks passed
@JohnJyong JohnJyong deleted the feat/add-tidb-on-qdrant-type branch October 25, 2024 05:57
idonotknow pushed a commit to AceDataCloud/Dify that referenced this pull request Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👻 feat:rag Embedding related issue, like qdrant, weaviate, milvus, vector database. lgtm This PR has been approved by a maintainer size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants