-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wildfire update #126
Open
Vedant1
wants to merge
25
commits into
main
Choose a base branch
from
wildfire_update
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Wildfire update #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Vedant1
commented
Nov 27, 2024
- created get_abstractions and update_abstractions functions in core.py for user to access the abstraction after using a plugin reader -- useful for existing examples
- updated csv reader/writer to use abstraction not pass through functions
- commented out several pass through functions in sqlite.py and file_reader.py
- updated test_sqlite.py to use newer sqlite functions -- no pass throughs
- updated all plugin readers to handle mismatched columns from several data files in same ingest (ex: results.toml and results1.toml)
- updated sqlite to handle mismatched columns for same table from different ingests to the sqlite db
- moved core functions around so plugin readers called when loaded, and only plugin writers require transload()
- no more transload lock anymore
- specified which function produces an error in error messages -- for user clarity
- updated wildfire and pennant examples to use DSI abstraction layer and new core functions/workflow
- updated examples.rst to use correct sqlite functions and updated pennant example
- updated dsi_units table in sqlite db write and read to separate col_name and units into two columns not one
…fit DSI abstraction
… and get_artifacts can return an orderedDict now
…eturn to update abstraction
…matched columns of same table
…ed by plugin writers, specified error locations in artifact_handler
…n in inspect artifact
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.