Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/thr momentum management #305

Merged
merged 3 commits into from
Oct 4, 2024

Conversation

joaogvcarneiro
Copy link
Collaborator

Description

This PR recreates the thrMomentumManagement module in C++ for further development. The first commit adds the module files, the second adds the unit test and the last adds documentation.

Verification

Test files were copied from the C module except for some minor adjustments.

Documentation

Ported the old module documentation into rst format.

Future work

This conversion is intended to be used in future additions.

@joaogvcarneiro joaogvcarneiro self-assigned this Aug 26, 2024
@joaogvcarneiro joaogvcarneiro linked an issue Aug 26, 2024 that may be closed by this pull request
@joaogvcarneiro joaogvcarneiro force-pushed the refactor/thrMomentumManagement branch 3 times, most recently from 5c643a9 to 49df0f8 Compare August 28, 2024 18:10
Copy link
Collaborator

@patkenneally patkenneally left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legend:
🔻 Issues to address before merge
🔶 Requests that should not block merge, but should at least be discussed
🔵 Recommendations that can be ignored if desired

@patkenneally patkenneally merged commit 99d17e6 into develop Oct 4, 2024
4 checks passed
@patkenneally patkenneally deleted the refactor/thrMomentumManagement branch October 4, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Convert thrMomentumManagement to C++
2 participants