Feature/515 new camera parameters #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patkenneally
requested changes
Sep 28, 2024
thibaudteil
force-pushed
the
feature/515-NewCameraParameters
branch
3 times, most recently
from
49c42f0
to
c4368f8
Compare
also add setters and getters for these new fields
patkenneally
force-pushed
the
feature/515-NewCameraParameters
branch
from
c4368f8
to
531c583
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A new camera model message was added. The difference to the old one is a new private field, some of the parameters are a duplicate from the old public field, some have different variable types, and new ones were also added. The simulation was modified to create and populate the new message.
Verification
Unit test was updated to test the reading and writing of the camera message
Documentation
Documentation was updated with the new camera model message
Future work
No future work