Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dockerfile to test installation of pljava and sep3 tools #52

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tfr42
Copy link
Member

@tfr42 tfr42 commented Sep 26, 2023

This PR adds a dockerfile for testing purposes. The dockerfile uses postgis/postgis as base image and installs pljava and sep3 tools.

@tfr42 tfr42 added the enhancement New feature or request label Sep 26, 2023
@tfr42
Copy link
Member Author

tfr42 commented Sep 26, 2023

@wanhoff Please review and add comments

@wanhoff
Copy link
Collaborator

wanhoff commented Sep 27, 2023

Hi @tfr42,

I created a docker container to run sep3 tools as well, so I guess we should integrate some stuff to your code. I notice some differences:

  • I used postgres without postgis. SEP3 should not need postgis
  • I implemented the shell script functions in a different way:
    • user, password and database are set in Dockerfile ENV variables
    • I decided to do the psql and java stuff in a sql file that is executed on container startup

I would add my changes to the branch.
I have not yet worked with combined java and docker projects, but I assume the sql file should go to /src/main/resources, right?

I have some more features for the docker image, but would add these later.

@tfr42
Copy link
Member Author

tfr42 commented Sep 27, 2023

Hi @tfr42,

I created a docker container to run sep3 tools as well, so I guess we should integrate some stuff to your code. I notice some differences:

* I used postgres without postgis. SEP3 should not need postgis

We use the container also as backend DB for deegree WFS with BML schema mapping. This requires PGIS and we would like to keep the PG extension pre-installed.

* I implemented the shell script functions in a different way:
  
  * user, password and database are set in Dockerfile ENV variables

The script uses the default environment variables used by psql, see https://www.postgresql.org/docs/current/libpq-envars.html

  * I decided to do the psql and java stuff in a sql file that is executed on container startup

Just push a new branch with your changes and we will compare.

I would add my changes to the branch. I have not yet worked with combined java and docker projects, but I assume the sql file should go to /src/main/resources, right?

Dockerfile and related ressource can be placed in the root directory, which is supported by docker maven plugin

I have some more features for the docker image, but would add these later.

@tfr42 tfr42 added the WIP work in progress label Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request WIP work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants