Desktop: Fixes #11261 : Ensure spell-check toggle works on macOS

[dhakarRaghu]

Desktop: Fixes #11261 : Ensure spell-check can be toggled off on macOS

This pull request addresses an issue where spell-check could not be fully disabled on the macOS desktop app, even when explicitly turned off in the settings.

Problem

On macOS, users encountered a problem when trying to disable spell-check. Although the setting was turned off, spell-check continued to underline words, suggesting that it wasn't fully disabled.

Solution

The fix ensures that:

• When users toggle spell-check off, the language list is set to an empty array, and the spell-checker is explicitly disabled in the session.
• When re-enabling, the spell-checker applies the correct languages and confirms that it is enabled in the session.

Technical Summary

• Updated the SpellCheckerServiceDriverNative.ts file to explicitly call setSpellCheckerEnabled(false) when disabling and setSpellCheckerEnabled(true) when enabling.
• Improved logging in setLanguages to track the session's state after each toggle and confirm that the changes have taken effect.

Testing

• Manually tested the toggling of spell-check on and off on the macOS desktop app to confirm that spell-check does not underline words when disabled.
• Verified that the correct language settings are applied upon re-enabling.

This PR resolves the underlying issue and provides a more consistent spell-check toggle experience on the macOS platform.

Reference: Fixes #11261

demo :

Screen.Recording.2024-11-13.at.10.33.59.PM.mov

[github-actions]

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

[dhakarRaghu]

I have read the CLA Document and I hereby sign the CLA

[laurent22]

Too many white space changes, deleted comments and log statements in this pull request. We can't merge it as it is

[laurent22]

Isn't it the same as this?

this.session().setSpellCheckerLanguages(effectiveLanguages);
this.session().setSpellCheckerEnabled(effectiveLanguages.length > 0);

[dhakarRaghu]

yes, The changes i have done and
this.session().setSpellCheckerLanguages(effectiveLanguages); this.session().setSpellCheckerEnabled(effectiveLanguages.length > 0);
are same.
Should i change my commit to this?

[laurent22]

yes