-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue2884 pid autotuning #2957
base: master
Are you sure you want to change the base?
Issue2884 pid autotuning #2957
Conversation
Buildings/Controls/OBC/CDL/Continuous/Validation/AMIGOWithFOTD.mo
Outdated
Show resolved
Hide resolved
Buildings/Controls/OBC/CDL/Continuous/Validation/AMIGOWithFOTD.mo
Outdated
Show resolved
Hide resolved
Buildings/Controls/OBC/CDL/Continuous/Validation/AMIGOWithFOTD.mo
Outdated
Show resolved
Hide resolved
Buildings/Controls/OBC/CDL/Continuous/Validation/PIDWithAutoTuning.mo
Outdated
Show resolved
Hide resolved
Buildings/Controls/OBC/CDL/Continuous/Validation/PIDWithAutoTuning.mo
Outdated
Show resolved
Hide resolved
Buildings/Resources/Scripts/Dymola/Controls/OBC/CDL/Continuous/Validation/PIDWithAutoTuning.mos
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SenHuang19: This requires considerable more work. Please also see the email I sent.
Issue2884 pid autotuning
issue2884 autotuning PID
@SenHuang19 Run the model |
@JayHuLBL Before merging the master branch, the results appear to be fine. I will thoroughly review it. |
|
Issue2884 pid autotuning
The CI test is failing with error as below:
|
The error with the license check occasionally occurs when the license manager takes too long to start and in the meantime Dymola proceeded without checking out the license. Restarting the CI tests helps. |
@mwetter Thanks! It now passed the test. I will have another look and then let you know if it is ready for your review. |
This merges the PID autotuning to the master.