Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue2884 pid autotuning #2957

Open
wants to merge 267 commits into
base: master
Choose a base branch
from
Open

Issue2884 pid autotuning #2957

wants to merge 267 commits into from

Conversation

mwetter
Copy link
Member

@mwetter mwetter commented Apr 11, 2022

This merges the PID autotuning to the master.

Copy link
Member Author

@mwetter mwetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SenHuang19: This requires considerable more work. Please also see the email I sent.

@JayHuLBL
Copy link
Contributor

@SenHuang19 Run the model Buildings.Fluid.HeatExchangers.Examples.WetCoilCounterFlowPControlAutoTuning, we have the results as below:
Screenshot 2024-11-19 at 10 50 26 PM
It seems that although the tuning process is triggered at 100 seconds and 2100 seconds, the control gain con.con.k and con.con.Ti constantly equal the start values. Could you please double check the results?

@SenHuang19
Copy link

@SenHuang19 Run the model Buildings.Fluid.HeatExchangers.Examples.WetCoilCounterFlowPControlAutoTuning, we have the results as below: Screenshot 2024-11-19 at 10 50 26 PM It seems that although the tuning process is triggered at 100 seconds and 2100 seconds, the control gain con.con.k and con.con.Ti constantly equal the start values. Could you please double check the results?

@JayHuLBL Before merging the master branch, the results appear to be fine. I will thoroughly review it.

@SenHuang19
Copy link

@SenHuang19 Run the model Buildings.Fluid.HeatExchangers.Examples.WetCoilCounterFlowPControlAutoTuning, we have the results as below: Screenshot 2024-11-19 at 10 50 26 PM It seems that although the tuning process is triggered at 100 seconds and 2100 seconds, the control gain con.con.k and con.con.Ti constantly equal the start values. Could you please double check the results?

@JayHuLBL Before merging the master branch, the results appear to be fine. I will thoroughly review it.

@JayHuLBL

  • The control gains, con.con.k and con.con.Ti, remain constant at the initial values because the first tuning attempt fails, as detailed in the log file.
  • The failure of the initial tuning is due to recent modifications to the valve, which appear to reduce the delay effects.
  • I made several adjustments to the example to ensure it works, including minor changes to the valve parameters and those of the relay controllers (see Issue2884 pid autotuning #4054) based on the updated response.

@JayHuLBL
Copy link
Contributor

The CI test is failing with error as below:

rCheck = checkModel("Buildings.Fluid.Movers.Validation.ControlledFlowMachineDynamic");
Pedantic check of Buildings.Fluid.Movers.Validation.ControlledFlowMachineDynamic
-------------------------------------------------
Error: the model is too complex for the current license.
Your license must be upgraded to handle this model.
-------------------------------------------------
Error: ERRORS have been issued.
Declaring variable: Boolean rCheck ;

@mwetter
Copy link
Member Author

mwetter commented Nov 22, 2024

The error with the license check occasionally occurs when the license manager takes too long to start and in the meantime Dymola proceeded without checking out the license. Restarting the CI tests helps.

@JayHuLBL
Copy link
Contributor

@mwetter Thanks! It now passed the test. I will have another look and then let you know if it is ready for your review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: To do
Development

Successfully merging this pull request may close these issues.

3 participants