Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue2884 pid autotuning #4054

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Issue2884 pid autotuning #4054

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2265980
remove unnecessary component
Nov 21, 2024
35aadd2
update example
Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions ...ilities/PIDWithAutotuning/SystemIdentification/FirstOrderTimeDelay/ControlProcessModel.mo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,9 +110,6 @@ protected
final k=-1)
"Product of the normalized time delay and -1"
annotation (Placement(transformation(extent={{-80,-70},{-60,-50}})));
Buildings.Controls.OBC.CDL.Reals.Abs abs1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we have the abs1 instance previously, and now delete it? Are we fixing the mistake here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the confusion. I deleted this because we have an abs instance in the timConDel block already.

"Absolute gain value"
annotation (Placement(transformation(extent={{-90,10},{-70,30}})));
Buildings.Controls.OBC.CDL.Logical.Not not1
"Check if an error occurs during the autotuning process"
annotation (Placement(transformation(extent={{40,-60},{60,-40}})));
Expand Down Expand Up @@ -173,10 +170,6 @@ equation
18,-26}}, color={0,0,127}));
connect(div.y, timConDel.rat) annotation (Line(points={{42,-20},{50,-20},{50,14},
{58,14}}, color={0,0,127}));
connect(gain.k, abs1.u)
annotation (Line(points={{-98,20},{-92,20}}, color={0,0,127}));
connect(abs1.y, samk.u)
annotation (Line(points={{-68,20},{-62,20}}, color={0,0,127}));
connect(and2.u1, not1.y) annotation (Line(points={{78,-70},{68,-70},{68,-50},{
62,-50}}, color={255,0,255}));
connect(and2.y, tunSta) annotation (Line(points={{102,-70},{106,-70},{106,-80},
Expand All @@ -189,6 +182,8 @@ equation
annotation (Line(points={{122,60},{132,60}}, color={255,0,255}));
connect(not2.u, timConDel.triFai) annotation (Line(points={{98,60},{96,60},{96,
12},{82,12}}, color={255,0,255}));
connect(gain.k, samk.u)
annotation (Line(points={{-98,20},{-62,20}}, color={0,0,127}));
annotation (
defaultComponentName = "conProMod",
Icon(coordinateSystem(preserveAspectRatio=false, extent={{-100,-100},{100,
Expand Down
7 changes: 4 additions & 3 deletions Buildings/Fluid/HeatExchangers/Examples/WetCoilCounterFlowPControlAutoTuning.mo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,8 @@ model WetCoilCounterFlowPControlAutoTuning
Buildings.Fluid.Actuators.Valves.TwoWayEqualPercentage val(
redeclare package Medium = Medium1,
m_flow_nominal=m1_flow_nominal,
dpValve_nominal=6000)
dpValve_nominal=6000,
strokeTime=240)
"Valve model"
annotation (Placement(transformation(extent={{30,50},{50,70}})));
Modelica.Blocks.Sources.TimeTable TSet(
Expand Down Expand Up @@ -96,9 +97,9 @@ model WetCoilCounterFlowPControlAutoTuning
Buildings.Controls.OBC.Utilities.PIDWithAutotuning.FirstOrderAMIGO
con(controllerType=Buildings.Controls.OBC.Utilities.PIDWithAutotuning.Types.SimpleController.PI,
u_s_start=288.15,
r=10,
r=5,
yLow=0.2,
deaBan=0.2,
deaBan=0.1,
yRef=0.5,
reverseActing=false)
"Controller"
Expand Down
Loading