Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable macOS universal binary builds #3516

Closed
wants to merge 1 commit into from
Closed

Enable macOS universal binary builds #3516

wants to merge 1 commit into from

Conversation

robd003
Copy link

@robd003 robd003 commented Dec 10, 2021

Python 3.9 supports universal2 builds so had to update to that

ref: #3515

@robd003
Copy link
Author

robd003 commented Dec 10, 2021

@jackrobison could you take a look at this when you get a moment?

@jackrobison
Copy link
Member

@robd003 does using universal builds require 3.9? If so then this is a little more involved - I know aiohttp had some breaking changes. I think it would be nice to update to 3.9 but if possible this can be a separate pr/issue.

@robd003
Copy link
Author

robd003 commented Dec 15, 2021

@robd003 does using universal builds require 3.9? If so then this is a little more involved - I know aiohttp had some breaking changes. I think it would be nice to update to 3.9 but if possible this can be a separate pr/issue.

Python 3.9 is required: https://docs.python.org/3/whatsnew/3.9.html#macos-11-0-big-sur-and-apple-silicon-mac-support

I can open another pull request to upgrade aiohttp to 3.6.1 and go through the rest of the modules that might need updating.

@eukreign
Copy link
Member

@robd003 i started porting SDK to Python 3.9 back in August, you are welcome to pickup where i left off. essentially the issue is that the tests monkey patch certain Python packages and in 3.9 this monkey patching is no longer allowed so the tests fail.

See PR: #3404

to get SDK to work on 3.9 would require refactoring these tests. i believe all of the affected tests are in the DHT module, perhaps @jackrobison or @shyba can provide further guidance.

@eukreign eukreign removed their assignment Dec 19, 2021
@robd003
Copy link
Author

robd003 commented Dec 19, 2021

@robd003 i started porting SDK to Python 3.9 back in August, you are welcome to pickup where i left off. essentially the issue is that the tests monkey patch certain Python packages and in 3.9 this monkey patching is no longer allowed so the tests fail.

See PR: #3404

to get SDK to work on 3.9 would require refactoring these tests. i believe all of the affected tests are in the DHT module, perhaps @jackrobison or @shyba can provide further guidance.

Awesome! I'll take a look at the PR and see if I can help :)

@eukreign eukreign assigned robd003 and unassigned jackrobison Dec 19, 2021
@eukreign
Copy link
Member

this has been moved up in priority and i'm going to pickup the PR i started back in August. we should sync up. are you on lbry discord?

@robd003
Copy link
Author

robd003 commented Dec 25, 2021

this has been moved up in priority and i'm going to pickup the PR i started back in August. we should sync up. are you on lbry discord?

@eukreign Could you send an invite link to the discord?

@eukreign
Copy link
Member

@kauffj
Copy link
Member

kauffj commented Jan 24, 2022

Closed pending Python 3.9 upgrade

@kauffj kauffj closed this Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants