Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure 2nd pass through transaction create loop will generate change > DUST. #3719

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Ensure 2nd pass through transaction create loop will generate change > DUST. #3719

wants to merge 5 commits into from

Commits on Dec 14, 2022

  1. Submit test_liquidate_at_loss() to repro bad TX missing output.

    @moodyjon
    moodyjon committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    2155681 View commit details
    Browse the repository at this point in the history

  2. Ensure 2nd pass through loop will generate change > DUST. 

    Drop double-count of Tx base fee from  cost_of_change.
    @moodyjon
    moodyjon committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    54932e4 View commit details
    Browse the repository at this point in the history

  3. Restore get_base_fee(ledger) in cost_of_change.

    @moodyjon
    moodyjon committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    2d1ef85 View commit details
    Browse the repository at this point in the history

  4. New logic for transaction create spends slightly less.

    @moodyjon
    moodyjon committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    6e76fa2 View commit details
    Browse the repository at this point in the history

  5. Fixup test after restoring get_base_fee(ledger) in cost_of_change.

    @moodyjon
    moodyjon committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    bea2089 View commit details
    Browse the repository at this point in the history