Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Nat): m / n = 0 ↔ n = 0 ∨ m < n #19505

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

YaelDillies
Copy link
Collaborator

From LeanCamCombi


Open in Gitpod

Copy link

github-actions bot commented Nov 26, 2024

PR summary 04f3842e4c

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@Command-Master
Copy link
Collaborator

Could you add "Moves: ..." to the PR description, as you can't deprecate the old names? Another option which I recall being taken once is to keep the old lemma's name, deprecate it, and use div_eq_zero_iff' for now

@YaelDillies
Copy link
Collaborator Author

YaelDillies commented Nov 26, 2024

Could you add "Moves: ..." to the PR description, as you can't deprecate the old names?

Confusingly (cc @eric-wieser), "Moves" means "renames", not "statement change" nor "relocation". So this PR contains no "Move".

@YaelDillies YaelDillies added the t-data Data (lists, quotients, numbers, etc) label Nov 26, 2024
@eric-wieser
Copy link
Member

Perhaps I read this PR wrong, but if I have

theorem a : A
theorem b : B

and change it to

theorem b : A
theorem c : B

then this should be recorded as a move from a to b and a move from b to c, not as a "statement change" of b.

@YaelDillies
Copy link
Collaborator Author

Then do you want me to add
Moves:

  • Nat.div_eq_zero_iff -> ``
  • Nat.div_ne_zero_iff -> ``
  • Nat.div_pos_iff -> ``

to the PR description? A less silly way to look at things is that I strengthened three lemmas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-data Data (lists, quotients, numbers, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants