-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(Pointwise): move auxiliary lemma out #19537
base: master
Are you sure you want to change the base?
Conversation
This has nothing to do with pointwise actions and doesn't need to be additivised
PR summary d4dfd042a1
|
File | Base Count | Head Count | Change |
---|---|---|---|
Mathlib.Order.Monotone.Basic | 170 | 171 | +1 (+0.59%) |
Import changes for all files
Files | Import difference |
---|---|
34 filesMathlib.GroupTheory.OreLocalization.OreSet Mathlib.Order.Filter.Defs Mathlib.Order.Circular Mathlib.GroupTheory.Subsemigroup.Center Mathlib.Data.Prod.Lex Mathlib.Algebra.Order.Monoid.Unbundled.OrderDual Mathlib.Algebra.Ring.Centralizer Mathlib.Data.Sigma.Order Mathlib.Order.MinMax Mathlib.Order.BoundedOrder.Lattice Mathlib.Data.Set.Subsingleton Mathlib.Algebra.Group.Center Mathlib.Order.PropInstances Mathlib.Data.List.SplitLengths Mathlib.Algebra.Group.Subsemigroup.Defs Mathlib.Data.Bundle Mathlib.Order.Monotone.Basic Mathlib.Order.Monotone.Monovary Mathlib.Order.BoundedOrder.Monotone Mathlib.Data.Part Mathlib.Order.Heyting.Basic Mathlib.Data.PSigma.Order Mathlib.Data.Nat.Order.Lemmas Mathlib.Data.SetLike.Basic Mathlib.Order.Iterate Mathlib.Algebra.Group.Submonoid.Defs Mathlib.Logic.Function.FiberPartition Mathlib.Data.Set.BoolIndicator Mathlib.Deprecated.MinMax Mathlib.Order.BooleanAlgebra Mathlib.Algebra.Order.Monoid.Unbundled.Defs Mathlib.Order.Lattice Mathlib.Data.Set.Basic Mathlib.Order.Disjoint |
1 |
Declarations diff
+ Group.card_nsmul_eq_card_nsmulpow_card_univ_aux
+ Group.card_pow_eq_card_pow_card_univ_aux
+ Nat.stabilises_of_monotone
- card_pow_eq_card_pow_card_univ_aux
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>
The doc-module for script/declarations_diff.sh
contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relative
value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolute
value is therelative
value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
alias Group.card_pow_eq_card_pow_card_univ_aux := Nat.stabilises_of_monotone | ||
|
||
@[deprecated (since := "2024-11-27")] | ||
alias Group.card_nsmul_eq_card_nsmulpow_card_univ_aux := Nat.stabilises_of_monotone |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like we should try to automatically detect if to_additive didn't modify the statement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not convinced yet that there isn't a legitimate use for it, but yes good idea
bors d+ |
✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with |
Co-authored-by: Bhavik Mehta <[email protected]>
As this PR is labelled bors merge |
This has nothing to do with pointwise actions and doesn't need to be additivised
This has nothing to do with pointwise actions and doesn't need to be additivised