Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Pointwise): move auxiliary lemma out #19537

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

YaelDillies
Copy link
Collaborator

This has nothing to do with pointwise actions and doesn't need to be additivised


Open in Gitpod

This has nothing to do with pointwise actions and doesn't need to be additivised
@YaelDillies YaelDillies added easy < 20s of review time. See the lifecycle page for guidelines. t-order Order theory labels Nov 27, 2024
Copy link

github-actions bot commented Nov 27, 2024

PR summary d4dfd042a1

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Order.Monotone.Basic 170 171 +1 (+0.59%)
Import changes for all files
Files Import difference
34 files Mathlib.GroupTheory.OreLocalization.OreSet Mathlib.Order.Filter.Defs Mathlib.Order.Circular Mathlib.GroupTheory.Subsemigroup.Center Mathlib.Data.Prod.Lex Mathlib.Algebra.Order.Monoid.Unbundled.OrderDual Mathlib.Algebra.Ring.Centralizer Mathlib.Data.Sigma.Order Mathlib.Order.MinMax Mathlib.Order.BoundedOrder.Lattice Mathlib.Data.Set.Subsingleton Mathlib.Algebra.Group.Center Mathlib.Order.PropInstances Mathlib.Data.List.SplitLengths Mathlib.Algebra.Group.Subsemigroup.Defs Mathlib.Data.Bundle Mathlib.Order.Monotone.Basic Mathlib.Order.Monotone.Monovary Mathlib.Order.BoundedOrder.Monotone Mathlib.Data.Part Mathlib.Order.Heyting.Basic Mathlib.Data.PSigma.Order Mathlib.Data.Nat.Order.Lemmas Mathlib.Data.SetLike.Basic Mathlib.Order.Iterate Mathlib.Algebra.Group.Submonoid.Defs Mathlib.Logic.Function.FiberPartition Mathlib.Data.Set.BoolIndicator Mathlib.Deprecated.MinMax Mathlib.Order.BooleanAlgebra Mathlib.Algebra.Order.Monoid.Unbundled.Defs Mathlib.Order.Lattice Mathlib.Data.Set.Basic Mathlib.Order.Disjoint
1

Declarations diff

+ Group.card_nsmul_eq_card_nsmulpow_card_univ_aux
+ Group.card_pow_eq_card_pow_card_univ_aux
+ Nat.stabilises_of_monotone
- card_pow_eq_card_pow_card_univ_aux

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Mathlib/Order/Monotone/Basic.lean Outdated Show resolved Hide resolved
alias Group.card_pow_eq_card_pow_card_univ_aux := Nat.stabilises_of_monotone

@[deprecated (since := "2024-11-27")]
alias Group.card_nsmul_eq_card_nsmulpow_card_univ_aux := Nat.stabilises_of_monotone
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like we should try to automatically detect if to_additive didn't modify the statement

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not convinced yet that there isn't a legitimate use for it, but yes good idea

@b-mehta
Copy link
Contributor

b-mehta commented Nov 27, 2024

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Nov 27, 2024

✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

Co-authored-by: Bhavik Mehta <[email protected]>
@YaelDillies YaelDillies added the auto-merge-after-CI Please do not add manually. Requests for a bot to merge automatically once CI is done. label Nov 27, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

As this PR is labelled auto-merge-after-CI, we are now sending it to bors:

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Nov 27, 2024
mathlib-bors bot pushed a commit that referenced this pull request Nov 27, 2024
This has nothing to do with pointwise actions and doesn't need to be additivised
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-after-CI Please do not add manually. Requests for a bot to merge automatically once CI is done. delegated easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-order Order theory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants