-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestions for FixDetMatsReps
#19545
base: FixDetMatsReps
Are you sure you want to change the base?
Conversation
jcommelin
commented
Nov 27, 2024
PR summary fdc072ff9e
|
File | Base Count | Head Count | Change |
---|---|---|---|
Mathlib.LinearAlgebra.Matrix.FixedDetMatrices | 1283 | 1284 | +1 (+0.08%) |
Import changes for all files
Files | Import difference |
---|---|
Mathlib.LinearAlgebra.Matrix.FixedDetMatrices |
1 |
Declarations diff
+ S_smul_four
+ T_S_rel
+ induction_on
+ reduce
+ reduceStep
+ reduce_mem_reps
+ reduce_of_not_pos
+ reduce_of_pos
+ reduce_rec
+ reduce_reduceStep
+ reps
+ repsFintype
+ reps_entries_le_m'
+ reps_zero_empty
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>
The doc-module for script/declarations_diff.sh
contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relative
value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolute
value is therelative
value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
bot fix style |
focus simp only [reduce_of_not_pos h h1] | ||
swap | ||
all_goals | ||
· simp only [reduce_of_pos h h1] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here I expanded the proof quite a bit. But I think that the massive all_goals simp only
is quite impenetrable. And hard to maintain if it might break at some point in the future.
I need to run now, so this bit isn't really polished. And I didn't attempt the other proof branch yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I'm responsible for that, I guess; I tried to combine the two massive simp only
s that used to be there before, as they were fairly similar.)