Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle closed PR status not showing properly #102

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Rizina
Copy link

@Rizina Rizina commented Oct 28, 2023

Fixes #101

Updated the code to properly identify the closed vs merged PRs

Screenshot 2023-10-28 at 6 39 34 PM

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@aws-amplify-ap-south-1
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-102.d1r8cuv7fofw0h.amplifyapp.com

Copy link
Member

@sbimochan sbimochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like github do not provide merged state. ref

<MergeStatus open={pullRequest.state === ISSUE_STATUS.OPEN} merged={pullRequest.state === ISSUE_STATUS.CLOSED} />
<MergeStatus
open={pullRequest.state === ISSUE_STATUS.OPEN}
merged={pullRequest.state === ISSUE_STATUS.CLOSED && pullRequest.pull_request.merged_at}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
merged={pullRequest.state === ISSUE_STATUS.CLOSED && pullRequest.pull_request.merged_at}
merged={pullRequest.state === ISSUE_STATUS.CLOSED && !!pullRequest.pull_request.merged_at}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect identification of closed PRs
2 participants