Соловьев Алексей. Задача 2. Вариант 12. Топология сети Звезда. #327
+356
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #327 +/- ##
==========================================
+ Coverage 96.31% 96.33% +0.01%
==========================================
Files 437 439 +2
Lines 11236 11283 +47
Branches 4739 4759 +20
==========================================
+ Hits 10822 10869 +47
Misses 136 136
Partials 278 278 ☔ View full report in Codecov by Sentry. |
NeeMiyuki
suggested changes
Nov 23, 2024
| #include "core/perf/include/perf.hpp" | ||
| #include "mpi/solovev_a_star_topology/include/ops_mpi.hpp" | ||
|
|
||
| std::vector<int> generate_random_vector(size_t size) { |
There was a problem hiding this comment.
this function should also be used in a func_tests to generate a random vector for tests
NeeMiyuki
approved these changes
Nov 24, 2024
aobolensk
requested changes
Nov 24, 2024
|
|
||
| #include "mpi/solovev_a_star_topology/include/ops_mpi.hpp" | ||
|
|
||
| std::vector<int> generate_random_vector(size_t size) { |
There was a problem hiding this comment.
Make it either static or wrap with namespace
| testMpiTaskParallel.post_processing(); | ||
| if (world.rank() == 0) { | ||
| for (size_t i = 0; i < input.size(); ++i) { | ||
| ASSERT_EQ(output[i], input[i]); |
There was a problem hiding this comment.
Add checks of received data on each data
| #include <vector> | ||
|
|
||
| #include "mpi/solovev_a_star_topology/include/ops_mpi.hpp" | ||
|
|
There was a problem hiding this comment.
Please, add tests that verify data transfer order
allnes
reviewed
Nov 25, 2024
|
|
||
| TEST(solovev_a_star_topology_mpi, Test_order) { | ||
| boost::mpi::communicator world; | ||
| if (world.size() > 1) { |
PutinVVV
suggested changes
Nov 27, 2024
PutinVVV
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Нулевой процесс, который является root процессом, получает на вход вектор целых чисел, который записывается в переменную input_, затем передаёт эту переменную всем остальным процессам, в свою очередь остальные процессы принимают эту переменную и передают её обратно в нулевой процесс, при получении этих данных нулевой процесс записывает их в переменную res, которая изначально инициализируется как вектор нулей такого же размера как и входные данные. В тестах происходит поэлементное сравнение входных данных и итогового результата.