Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE UNTIL KDS v5.0.0-rc3 INSTALLED] Remove hard-coded vuetify color on hover using $darken_ utitlity #4688

Open
wants to merge 1 commit into
base: unstable
Choose a base branch
from

Conversation

shivam-daksh
Copy link
Contributor

Summary

This PR addresses the issue of replacing the Vuetify color with the Kolibri Design System's (KDS) darken utility. Specifically, it updates the background color for the button that uses the Vuetify --v-error-darken1 color variable.

Changes Made

  • Replaced the usage of var(--v-error-darken1) with the corresponding $darken_ utility from the Kolibri Design System once it is provided.
  • Updated the button's background color to maintain the appropriate shade when not in the hovered state, ensuring consistency with the KDS design standards.

Testing

  • Verified that the button's color remains consistent with the Kolibri Design System's color palette.
  • Ensured that the color updates do not affect other components.

Additional Context

This change improves the alignment with the Kolibri Design System and helps maintain design consistency across the application.

Screenshots (if applicable)

Does this introduce any tech-debt items?


Reviewer guidance

How can a reviewer test these changes?

Are there any risky areas that deserve extra testing?

References

#4634

Comments


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@MisRob MisRob requested a review from ozer550 August 29, 2024 17:48
@MisRob MisRob assigned MisRob and unassigned MisRob Aug 29, 2024
@MisRob MisRob self-requested a review August 29, 2024 17:49
@MisRob
Copy link
Member

MisRob commented Aug 29, 2024

Thanks @shivam-daksh! I will invite my colleague @ozer550 to review.

Even though we can complete the review, just leaving a note here that we will merge it after the newest KDS release containing $darken utility is installed into Studio.

@MisRob MisRob changed the title Remove hard-coded vuetify color on hover using $darken_ utitlity [DO NOT MERGE UNTIL KDS v5.0.0-rc3 INSTALLED] Remove hard-coded vuetify color on hover using $darken_ utitlity Aug 29, 2024
Copy link
Member

@ozer550 ozer550 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look correct to me! I have tested them out locally and the results are similar.

Copy link
Member

@MisRob MisRob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @shivam-daksh and @ozer550. All looks good to me too! We will merge as soon as this KDS release is in Studio (that should also resolve the tests failure).

@MisRob MisRob self-assigned this Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants