Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #322 (Union[Literal, ...]) #325

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Fix #322 (Union[Literal, ...]) #325

wants to merge 1 commit into from

Conversation

lebrice
Copy link
Owner

@lebrice lebrice commented Sep 5, 2024

@lebrice
Add test to repro #322
1a8f5c6 
Signed-off-by: Fabrice Normandin <[email protected]>
JasonGross
JasonGross reviewed Sep 7, 2024
View reviewed changes
test/test_literal.py
Comment on lines +137 to +138
# TODO: What about this again?
assert parse(Foo, args="--bar=1.23") == Foo(bar=1)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should fail, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JasonGross JasonGross JasonGross left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lebrice @JasonGross