Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialised project with Typescript and Rollup bundle #2

Closed
wants to merge 3 commits into from

Conversation

Janvi-Thakkar
Copy link

Initialised project with Typescript and Rollup bundle

##Related Issue
This PR fixes #1

##Steps

  1. run command "npm init -y" to initialize package.json
  2. run command "npm install --save-dev rollup typescript"
  3. run command "npm install --save-dev @open-wc/building-rollup"
  4. run command "tsc --init" to initialize tsconfig.json
  5. made "rollup.config.js" and changed file content
  6. changed tsconfig.json content
  7. added build script in package.json
  8. made src folder and one trial.ts file ( src folder and atleast 1 .ts file is required to provide as typescript entry point
  9. npm run build

Checklist:

  • My code follows the code style of this project.

@Janvi-Thakkar Janvi-Thakkar marked this pull request as ready for review February 9, 2022 17:47
@Janvi-Thakkar
Copy link
Author

@charithccmc can you please review this?

@PrerakMathur20 PrerakMathur20 mentioned this pull request Mar 5, 2022
2 tasks
@agentmilindu
Copy link
Contributor

Let’s follow the commonly accepted best practices for the commit messages. Ref here

@Janvi-Thakkar
Copy link
Author

Janvi-Thakkar commented Mar 6, 2022

Let’s follow the commonly accepted best practices for the commit messages. Ref here

@agentmilindu, Thank you for this reference. I will follow this practice from now onwards. Can you please suggest to me what should I do to improve the PR? Is it allowed to force push in this condition?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initialising the project using typescript and rollup as a bundle
2 participants