WIP remove $configuration, and clean up exec, upload and download #356
Conversation
| use Psr\Log\LoggerInterface; | ||
| use Http\Adapter\Guzzle7\Client as GuzzleAdapter; |
There was a problem hiding this comment.
There must be one blank line after the last USE statement; 2 found;
src/JiraClient.php
Outdated
| * @param ConfigurationInterface|ClientInterface|null $configuration | ||
| * @throws JiraException | ||
| */ | ||
| private function configureClient($configuration = null, string $path ="./"): void { |
There was a problem hiding this comment.
- Incorrect spacing between default value and equals sign for argument
$path; expected 1 but found 0 - Opening brace should be on a new line
src/JiraClient.php
Outdated
| * 204: The server successfully processed the request, but is not returning any content. | ||
| */ | ||
| if ($this->http_response === 204 || $this->http_response === 201 || $this->http_response === 200) { | ||
| if(!$content) { |
There was a problem hiding this comment.
Expected 1 space after IF keyword; 0 found
src/JiraClient.php
Outdated
| // curl_setopt($ch, CURLOPT_FOLLOWLOCATION, true); cannot be activated when an open_basedir is set | ||
| if (!function_exists('ini_get') || !ini_get('open_basedir')) { | ||
| curl_setopt($ch, CURLOPT_FOLLOWLOCATION, true); | ||
| if (!in_array($this->http_response, [201,200], true)){ |
There was a problem hiding this comment.
Expected 1 space after closing parenthesis; found 0
src/JiraClient.php
Outdated
| $this->log->error($msg); | ||
|
|
||
| curl_close($ch); | ||
| $request = new Request("POST",$url,['Content-Type' => 'multipart/form-data'],new Stream(fopen($file, "r+b"))); |
There was a problem hiding this comment.
No space found after comma in function call
src/JiraClient.php
Outdated
|
|
||
| $this->log->debug('Curl exec='.$url); | ||
| $response = curl_exec($ch); | ||
| $response = $this->client->sendRequest(new Request("GET",$url)); |
There was a problem hiding this comment.
No space found after comma in function call
src/JiraClient.php
Outdated
|
|
||
| if (!in_array($this->http_response,[200,201], true)) { |
There was a problem hiding this comment.
No space found after comma in function call
src/JiraClient.php
Outdated
| } | ||
|
|
||
| while (!$stream->eof()) { | ||
| fwrite($outputFile,$stream->read(4096)); |
There was a problem hiding this comment.
No space found after comma in function call
|
What? this is not ready :S |
|
hi @Richard87 i'm sorry, i was not meticulous at this PR, so this PR is build broken. could make hot fix please? |
|
Hi! I'm not sure if I can? I think you'll have to revert the commit, and push a new head, but I'm not good enough in Git, or have access to the git repository to make it happen... I can delete all my changes, and make a new commit with basically 0 changes, so you can merge it in? |
|
hi! i'm remove your PR and revert master branch to last commit. if you are create new PR branch, you should send to 3.0.0-alpha branch please. thanks!. |
|
Great, thats perfect! |
WIP
Solves #355