Implement looking for manually installed idea on windows #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyze237
force-pushed
the
findideamanually
branch
from
1ecf594
to
d578dc1
Compare
|
I just noticed the flatpak check from #159 isn't included, i'll re-add that one too. |
|
This needs some testing but should be the same as from the previous PR |
tommyettinger
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey!
I’ve created a quick PR that adds functionality for the “Open in IntelliJ” button to detect manually installed IntelliJ versions.
The sorting is based on the “last modified” date, so it should ideally open the most recently installed version.
Since Liftoff doesn’t run in a Windows sandbox, I couldn’t fully test it myself. However, I did test it using jshell by copying and pasting the code line by line. I prefer not to install IntelliJ manually on my PC.
It might be beneficial to identify the default install locations for Mac and Linux as well, but I think Linux are good enough to figure out a disabled button might have a tooltip.