Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: deadlock on panic in transport testsuite #2934

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: deadlock on panic in transport testsuite #2934

wants to merge 2 commits into from

Commits on Sep 10, 2024

  1. fix: deadlock on panic in transport testsuite 

    I had a panic in `list.Multiaddr()` which would deadlock the test instead of properly showing up the stack trace.

This happens because in the defer block it waits for <-done however because the test never proceed the other goroutine is stuck on `.Accept()`, never sending `close(done)`.
    @Jorropo @sukunrt
    Jorropo authored and sukunrt committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    cf1e554 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2024

  1. Merge branch 'master' into fix-deadlock-on-panic

    @p-shahi
    p-shahi authored Dec 2, 2024
    Configuration menu
    Copy the full SHA
    e20d1b3 View commit details
    Browse the repository at this point in the history