Add RETRO_ENVIRONMENT_GET_CORE_DATA example usage
#30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobLoach
changed the title
RETRO_ENVIRONMENT_GET_CORE_DATA example usage
|
Setting this as a draft, as it's just a demonstration of using the new environment callbacks. |
JesseTG
suggested changes
Sep 29, 2024
| @@ -8,9 +8,19 @@ | |||
|
|
|||
| #include "libretro.h" | |||
|
|
|||
| static uint32_t *frame_buf; | |||
| typedef struct core_data_t { | |||
There was a problem hiding this comment.
I think to really demonstrate this envcall, you'd need to move all currently-static state into it
There was a problem hiding this comment.
That would be awesome. I'll see how much can be moved. Some of the callbacks are called before the core is initialized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an example of using the
RETRO_ENVIRONMENT_GET_CORE_DATAandRETRO_ENVIRONMENT_SET_CORE_DATAenvironment callback to allow avoiding having static/global core variables.Depends on libretro/RetroArch#17012 .