Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-189491 Replace Collapse by ClayPanel #13221

Closed
wants to merge 9 commits into from
Closed

LPS-189491 Replace Collapse by ClayPanel #13221

wants to merge 9 commits into from

Conversation

alessandromalves
Copy link

@alessandromalves alessandromalves commented Aug 9, 2023 •
edited
Loading

Dear frontend reviewer,

There are several things that the ClayPanel component doesn't have by default, such as a c-inner and styles defined in Lexicon. I have opened a question here liferay/clay#5624 for Clay and we have to wait for it to be solved before merging this code.

cc.: @veroglez

@liferay-page-management
Copy link
Owner

Thank you for submitting this PR. 👏

Make sure it follows the Echo Pull Request Template if you haven't already done so.

Learn more about it here.

@liferay-page-management liferay-page-management added 🔍 Frontend Review Needed Frontend code needs to be reviewed by a member of the team. 🔍 QA Review Needed labels Aug 9, 2023
@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@alessandromalves alessandromalves added ✅ Ready to Merge Pull request is ready and can be forwarded. and removed 🔍 Frontend Review Needed Frontend code needs to be reviewed by a member of the team. 🔍 QA Review Needed labels Aug 9, 2023
@alessandromalves
Copy link
Author

ci:test:sf

@alessandromalves alessandromalves mentioned this pull request Aug 9, 2023
Closed
@alessandromalves
Copy link
Author

Resent based on #12752

@alessandromalves alessandromalves changed the title LPS-189491 LPS-189491 Replace Collapse by ClayPanel Aug 9, 2023
@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 5 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 9b9c8fb8ca1d46ef6dab8c306728ac782a8c962f

Sender Branch:

Branch Name: LPS-189491_QA_REVIEW
Branch GIT ID: 828bc7ae6044d9e57ffa25e1d87c755d4b48cce1

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@alessandromalves
Copy link
Author

ci:forward

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

The pull request will automatically be forwarded to the user brianchandotcom If the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration
Copy link
Collaborator

Skipping previously passed test suites:

  • ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 29 out of 29 jobs passed

❌ ci:test:relevant - 296 out of 320 jobs passed in 3 hours 24 minutes

Click here for more details.

This pull is eligible for reevaluation. When this upstream build has completed, using the following CI command will compare this pull request result against a more recent upstream result:

ci:reevaluate:1407401_5039

Base Branch:

Branch Name: master
Branch GIT ID: 9b9c8fb8ca1d46ef6dab8c306728ac782a8c962f

Upstream Comparison:

Branch GIT ID: ffa3ce6483f058300d4476a5580521483e51f411
Jenkins Build URL: EE Development Acceptance (master) - 4733 - 2023-08-08[12:43:32]

ci:test:stable - 29 out of 29 jobs PASSED
29 Successful Jobs:
    ci:test:relevant - 296 out of 320 jobs PASSED

    24 Failed Jobs:

    296 Successful Jobs:
      For more details click here.

      Failures unique to this pull:

      6. ...

      @liferay-continuous-integration
      Copy link
      Collaborator

      @ealonso
      Copy link
      Collaborator

      ealonso commented Aug 11, 2023

      ci:forward

      @liferay-continuous-integration
      Copy link
      Collaborator

      CI is automatically triggering the following test suites:

      •     ci:test:relevant
      •     ci:test:sf
      •     ci:test:stable

      The pull request will automatically be forwarded to the user brianchandotcom If the following test suites pass:

      •     ci:test:relevant
      •     ci:test:sf
      •     ci:test:stable

      @liferay-continuous-integration
      Copy link
      Collaborator

      Skipping previously passed test suites:

      • ci:test:sf
      • ci:test:stable

      @alessandromalves
      Copy link
      Author

      ci:forward:force

      @liferay-continuous-integration
      Copy link
      Collaborator

      CI is automatically triggering the following test suites:

      •     ci:test:relevant
      •     ci:test:sf
      •     ci:test:stable

      The pull request will automatically be forwarded to the user brianchandotcom if the following test suites complete:

      •     ci:test:relevant
      •     ci:test:sf
        AND If the following test suites pass:
      •     ci:test:stable

      @liferay-continuous-integration
      Copy link
      Collaborator

      Skipping previously completed test suites:

      • ci:test:relevant
      • ci:test:sf
        AND Skipping previously passed test suites:
      • ci:test:stable

      @liferay-continuous-integration
      Copy link
      Collaborator

      All required test suite(s) completed.
      Forwarding pull request to brianchandotcom.
      Console

      @liferay-continuous-integration
      Copy link
      Collaborator

      Error has occurred while attempting to forward pull request to brianchandotcom. Retrying in 1 minute...
      See console log for detail:Full Console

      1 similar comment
      @liferay-continuous-integration
      Copy link
      Collaborator

      Error has occurred while attempting to forward pull request to brianchandotcom. Retrying in 1 minute...
      See console log for detail:Full Console

      @liferay-continuous-integration
      Copy link
      Collaborator

      Error has occurred while forwarding pull request to brianchandotcom.
      Please try again later or contact the CI team for assistance.
      See console log for details: Full Console

      @ealonso
      Copy link
      Collaborator

      ealonso commented Aug 11, 2023

      ci:forward:force

      @liferay-continuous-integration
      Copy link
      Collaborator

      CI is automatically triggering the following test suites:

      •     ci:test:relevant
      •     ci:test:sf
      •     ci:test:stable

      The pull request will automatically be forwarded to the user brianchandotcom if the following test suites complete:

      •     ci:test:relevant
      •     ci:test:sf
        AND If the following test suites pass:
      •     ci:test:stable

      @liferay-continuous-integration
      Copy link
      Collaborator

      Skipping previously completed test suites:

      • ci:test:relevant
      • ci:test:sf
        AND Skipping previously passed test suites:
      • ci:test:stable

      @alessandromalves
      Copy link
      Author

      alessandromalves commented Aug 11, 2023 •
      edited
      Loading

      The failures are not related to this PR (comparison with acceptance routine here). See brianchandotcom#139109

      @alessandromalves alessandromalves mentioned this pull request Aug 11, 2023
      Merged
      @liferay-continuous-integration
      Copy link
      Collaborator

      ✔️ ci:test:stable - 29 out of 29 jobs passed

      ❌ ci:test:relevant - 297 out of 323 jobs passed in 5 hours 39 minutes

      Click here for more details.

      This pull is eligible for reevaluation. When this upstream build has completed, using the following CI command will compare this pull request result against a more recent upstream result:

      ci:reevaluate:1317401_9018

      Base Branch:

      Branch Name: master
      Branch GIT ID: c06135d6ad5268e9d28d3bcd6e5af328d7e26d66

      Upstream Comparison:

      Branch GIT ID: a3456a4c41f46d4951bc070a4af5876263459e6c
      Jenkins Build URL: EE Development Acceptance (master) - 4735 - 2023-08-10[20:42:51]

      ci:test:stable - 29 out of 29 jobs PASSED
      29 Successful Jobs:
        ci:test:relevant - 297 out of 323 jobs PASSED

        26 Failed Jobs:

        297 Successful Jobs:
          For more details click here.

          Failures unique to this pull:

          1. semantic-versioning-jdk8/0/0
                 [exec] > Task :apps:headless:headless-form:headless-form-client:compileJava FAILED
     [exec] 
     [exec] > Task :apps:headless:headless-discovery:headless-discovery-web:packageRunBuild
     [exec] warning package.json: No license field
     [exec] yarn run v1.13.0
     [exec] \$ liferay-npm-scripts webpack
     [exec] Browserslist: caniuse-lite is outdated. Please run:
     [exec] npx browserslist@latest --update-db
     [exec] 
     [exec] Why you should do it regularly:
     [exec] https://github.com/browserslist/browserslist#browsers-data-updating
     [exec] 
     [exec] > Task :apps:commerce:commerce-theme-speedwell:commerce-theme-speedwell:packageRunBuild
     [exec] Browserslist: caniuse-lite is outdated. Please run:
     [exec] npx browserslist@latest --update-db
     [exec] 
     [exec] Why you should do it regularly:
     [exec] https://github.com/browserslist/browserslist#browsers-data-updating
     [exec] [21:34:15] gulp-postcss: clay.css
     [exec] autoprefixer: /opt/dev/projects/github/liferay-portal/modules/apps/commerce/commerce-theme-speedwell/commerce-theme-speedwell/build/_css/clay.css:24353:3: Please do not use display: contents; if you have grid setting enabled
     [exec] autoprefixer: /opt/dev/projects/github/liferay-portal/modules/apps/commerce/commerce-theme-speedwell/commerce-theme-speedwell/build/_css/clay.css:24398:5: Please do not use display: contents; if you have grid setting enabled
     [exec] autoprefixer: /opt/dev/projects/github/liferay-portal/modules/apps/commerce/commerce-theme-speedwell/commerce-theme-speedwell/build/_css/clay.css:24443:5: Please do not use display: contents; if you have grid setting enabled
     [exec] autoprefixer: /opt/dev/projects/github/liferay-portal/modules/apps/commerce/commerce-theme-speedwell/commerce-theme-speedwell/build/_css/clay.css:24488:5: Please do not use display: contents; if you have grid setting enabled
     [exec] autoprefixer: /opt/dev/projects/github/liferay-portal/modules/apps/commerce/commerce-theme-speedwell/commerce-theme-speedwell/build/_css/clay.css:24533:5: Please do not use display: contents; if you have grid setting enabled
     [exec] autoprefixer: /opt/dev/projects/github/liferay-portal/modules/apps/commerce/commerce-theme-speedwell/commerce-theme-speedwell/build/_css/clay.css:24582:5: Please do not use display: contents; if you have grid setting enabled
     [exec] 
     [exec]   Replace Autoprefixer browsers option to Browserslist config.
            1. com.liferay.jenkins.Jenkins

          @liferay-continuous-integration
          Copy link
          Collaborator

          Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
          Reviewers
          No reviews
          Assignees
          No one assigned
          Labels
          ci:test:relevant - failure ci:test:sf - success ci:test:stable - success ✅ Ready to Merge Pull request is ready and can be forwarded.
          Projects
          None yet
          Milestone
          No milestone
          Development

          Successfully merging this pull request may close these issues.
          5 participants
          @alessandromalves @liferay-page-management @liferay-continuous-integration @veroglez @ealonso