feat(@clayui/css): LPD-40160 Adds menubar-primary for CMS Product Menu variant #5898
Conversation
|
@marcoscv-work any recommendations for this one? |
|
Hey guys @ethib137 @pat270 if we use |
… for CMS Product Menu variant
…enu in VerticalNav
packages/clay-core/src/nav/Link.tsx
Outdated
| @@ -52,6 +52,40 @@ export const Link = React.forwardRef< | |||
| }, | |||
| ref | |||
| ) => { | |||
| if (showIcon) { | |||
There was a problem hiding this comment.
This change here will probably break tests in DXP due to button being changed to div.
|
Hey @pat270, what's the status on this one? Also, it looks like keyboard navigation for vertical nav is broken by this PR. |
|
@ethib137 I wasn't able to fix the the keyboard navigation. I had to rearrange the markup due to button in button React error. I believe the keyboard navigation isn't working for this because the text is nested inside other elements.
|
|
I might take a look at it this week if I can't get it moving @pat270. |
|
@matuzalemsteles and @pat270 we need this ASAP. Please prioritize getting this fixed and released. Thanks guys. |
|
@ethib137 keyboard navigation works for the other vertical navs. It's only broken for the primary variant. |
|
That's odd... we need it to work for primary too. |
… `displayType` primary
|
I fixed the navigation bug for primary, it wasn't working because we have a hook that handles navigation for our components but it was only being applied to the old VerticalNav and not to the new variant. |
|
Thanks @matuzalemsteles! I'll update the tests |
https://liferay.atlassian.net/browse/LPD-40160
I'm sending this as a draft because we have a problem with the accordion headers. They can only be
buttonand in some of the headers we have nested plus buttons. Having abuttonnested in abuttonviolates:from the w3c spec. I need some help figuring out which component we should place
<div role="button">to make our markup valid.