Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

Fixed: whitelisting multiple sass directories for build-css goal not possible in version 6.2.10.16 #19

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ktor
Copy link

@ktor ktor commented Feb 27, 2018

Theme plugin build ends with null pointer exception if following configuration is used with liferay 6.2:

                <groupId>com.liferay.maven.plugins</groupId>
                <artifactId>liferay-maven-plugin</artifactId>
                <version>6.2.10.16</version>
                <executions>
                    <execution>
                        <phase>generate-sources</phase>
                        <goals>
                            <goal>theme-merge</goal>
                            <goal>build-css</goal>
                            <goal>build-thumbnail</goal>
                        </goals>
                    </execution>
                </executions>
                <configuration>
                    <sassDirNames>/theme1/css,/theme2/css,/theme3/css</sassDirNames>
                    (...)
                </configuration>
            </plugin>

Problematic line

Solution, removed condition that sassDirNames are processed only for liferay version lower than 6.2. Liferay 6.2 is prepared for multiple values in the sassDirNames list

ktor added 2 commits February 27, 2018 15:36
…ure whitelist of multiple sass directories for sass preprocessor (build-css)
…ure whitelist of multiple sass directories for sass preprocessor (build-css), fixed whitespacing
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant