-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Documentation for lightly/models/modules #1704
Add Documentation for lightly/models/modules #1704
Conversation
…yush22iitbhu/lightly-repo into cleanup_lightly/models/modules
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1704 +/- ##
=======================================
Coverage 84.90% 84.90%
=======================================
Files 156 156
Lines 6526 6526
=======================================
Hits 5541 5541
Misses 985 985 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks a lot!
I made two suggestions to make the docstrings a bit more helpful.
@MalteEbner I have done the changes for adding shape of tensors in docstring. Could you elaborate more on the adding typing in the function arguments? |
Hey @ayush22iitbhu, thanks for adding the tensor shapes! Sorry for this back-and-forth. I approved your commit as it is :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done!
#1687
I have updated the docstrings for the following files: