Consistently connect to Unix sockets

[tamird]

See commit message.

[tamird]

r? @nirs

[AkihiroSuda]

I don't think we have to introduce a new netutil package just for avoiding this single type assertion.

If you want to avoid a potential panic, you can just check conn, ok := unixConn.(*net.UnixConn); if !ok { return errors.New(...)}

[tamird]

I don't think we have to introduce a new netutil package just for avoiding this single type assertion.

Because this pattern occurs in a number of places (connecting to a UNIX socket, not the type assertion), this is reducing all that duplication.

If you want to avoid a potential panic, you can just check conn, ok := unixConn.(*net.UnixConn); if !ok { return errors.New(...)}

I don't think a panic is a real concern. This is just cleanup.

[tamird]

@nirs this is what you wanted, no?

[nirs]

@nirs this is what you wanted, no?

I suggested to add a helper which would solve the issue for the vz package. The current change is little bit bigger and handle all unix sockets in lima (good), but it is hard to sell it as a way to avoid type assertions since we have only one.

I did have time to review all the changes, but I think this will be easier to swallow if we change the commit/pr title/message to describe why creating unix socket in this way is better.

[tamird]

Updated both the PR title and the commit message.

[tamird]

Would appreciate a review here!

[AkihiroSuda]

The amount of the deduplicated code is trivial.
I'm not sure this is worth adding a new "util" pkg.

[nirs]

If we remove the unneeded and possibly unwanted change to ignore the context in many places, the actual change is very small, maybe only in vz/network_darwin.go?

But since the change is so small, I'm not sure it worth the effort. The benefit is very small. Better to invest time on stuff that add more value.