Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed depth launch to not evaluate dict when and fail when sensor other then oakd is used #95

Closed
wants to merge 1 commit into from

Conversation

gitisacatsname
Copy link

as stated here:
#94

…ther then oakd type is used.

Signed-off-by: git is a cats name <[email protected]>
@gitisacatsname
Copy link
Author

ah, forgot to state also fixed property name for realsense sensor as this changed since wrapper is out of beta.

@grassjelly
Copy link
Member

grassjelly commented Oct 14, 2023

hi, thanks for the PR. Could we try this instead? It's quite hard to debug that PythonExpression in the future in case it breaks again. I don't have an oak-d so this approach might be less intrusive.

  IncludeLaunchDescription(
      PythonLaunchDescriptionSource(PathJoinSubstitution(
          [FindPackageShare('depthai_examples'), 'launch', 'stereo.launch.py']
      )),
      condition=IfCondition(PythonExpression(['"', LaunchConfiguration('sensor'), '" in "', str(oakd_sensors), '"'])),
      launch_arguments={
          'camera_model': to_oakd_vars.get(LaunchConfiguration('sensor')], "UNKNOWN"),                
      }.items()   
  ),

@grassjelly grassjelly closed this Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants